Make setResourceAttributesFilter public (#319)

Author: psx95

exporters/metrics/src/main/java/com/google/cloud/opentelemetry/metric/MetricConfiguration.java

@@ -215,9 +215,6 @@ public final Builder setProjectId(String projectId) {
     /** Sets the endpoint where to write Metrics. Defaults to monitoring.googleapis.com:443. */
     public abstract Builder setMetricServiceEndpoint(String endpoint);
 
-    @VisibleForTesting
-    abstract Builder setInsecureEndpoint(boolean value);
-
     /**
      * Set a filter to determine which resource attributes to add to metrics as metric labels. By
      * default, it adds service.name, service.namespace, and service.instance.id. This is
@@ -229,7 +226,10 @@ public final Builder setProjectId(String projectId) {
      *     metric label
      * @return this.
      */
-    abstract Builder setResourceAttributesFilter(Predicate<AttributeKey<?>> filter);
+    public abstract Builder setResourceAttributesFilter(Predicate<AttributeKey<?>> filter);
+
+    @VisibleForTesting
+    abstract Builder setInsecureEndpoint(boolean value);
 
     abstract MetricConfiguration autoBuild();
 

exporters/metrics/src/test/java/com/google/cloud/opentelemetry/metric/MetricConfigurationTest.java

@@ -24,7 +24,10 @@
 import com.google.auth.oauth2.GoogleCredentials;
 import com.google.cloud.ServiceOptions;
 import com.google.cloud.opentelemetry.metric.MetricConfiguration.Builder;
+import io.opentelemetry.api.common.AttributeKey;
+import java.time.Duration;
 import java.util.Date;
+import java.util.function.Predicate;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.JUnit4;
@@ -49,14 +52,17 @@ public void testDefaultConfigurationSucceeds() {
 
   @Test
   public void testSetAllConfigurationFieldsSucceeds() {
+    Predicate<AttributeKey<?>> allowAllPredicate = attributeKey -> true;
     MetricConfiguration configuration =
         MetricConfiguration.builder()
             .setProjectId(PROJECT_ID)
             .setCredentials(FAKE_CREDENTIALS)
+            .setResourceAttributesFilter(allowAllPredicate)
             .build();
 
     assertEquals(FAKE_CREDENTIALS, configuration.getCredentials());
     assertEquals(PROJECT_ID, configuration.getProjectId());
+    assertEquals(allowAllPredicate, configuration.getResourceAttributesFilter());
   }
 
   @Test
@@ -66,6 +72,19 @@ public void testConfigurationWithEmptyProjectIdFails() {
     assertThrows(IllegalArgumentException.class, () -> builder.setProjectId(null));
   }
 
+  @Test
+  public void testConfigurationWithNegativeDeadlineFails() {
+    MetricConfiguration.Builder builder =
+        MetricConfiguration.builder().setDeadline(Duration.ofSeconds(-1));
+    assertThrows(IllegalArgumentException.class, builder::build);
+  }
+
+  @Test
+  public void testConfigurationWithNullResourceAttributesFilterFails() {
+    Builder builder = MetricConfiguration.builder();
+    assertThrows(NullPointerException.class, () -> builder.setResourceAttributesFilter(null));
+  }
+
   @Test
   public void testConfigurationWithDefaultProjectIdSucceeds() {
     try (MockedStatic<ServiceOptions> serviceOptionsMockedStatic =