Fix creation of resources in _detector

xrmx · xrmx · commit 1160c321f5fa · 2024-12-24T10:13:27.000+01:00
We should create a Resource instance and not use Resource.create because if we set OTEL_EXPERIMENTAL_RESOURCE_DETECTORS we will go into an infinite loop trying to load and instantiate all the resources detectors. Fix #363
diff --git a/opentelemetry-resourcedetector-gcp/src/opentelemetry/resourcedetector/gcp_resource_detector/_detector.py b/opentelemetry-resourcedetector-gcp/src/opentelemetry/resourcedetector/gcp_resource_detector/_detector.py
@@ -129,7 +129,7 @@ def _gae_resource() -> Resource:
 
 
 def _make_resource(attrs: Mapping[str, AttributeValue]) -> Resource:
-    return Resource.create(
+    return Resource(
         {
             ResourceAttributes.CLOUD_PROVIDER: "gcp",
             ResourceAttributes.CLOUD_ACCOUNT_ID: _metadata.get_metadata()[

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ def _gae_resource() -> Resource:`
`129`	`129`
`130`	`130`
`131`	`131`	`def _make_resource(attrs: Mapping[str, AttributeValue]) -> Resource:`
`132`		`- return Resource.create(`
	`132`	`+ return Resource(`
`133`	`133`	`{`
`134`	`134`	`ResourceAttributes.CLOUD_PROVIDER: "gcp",`
`135`	`135`	`ResourceAttributes.CLOUD_ACCOUNT_ID: _metadata.get_metadata()[`