Skip to content

Commit 2363dd1

Browse files
committed
Fix example usage in README, make other minor
changes based on feedback in PR.
1 parent 91a2026 commit 2363dd1

File tree

3 files changed

+4
-25
lines changed

3 files changed

+4
-25
lines changed

opentelemetry-exporter-gcp-logging/README.rst

Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,6 @@ Usage
3939
from opentelemetry.exporter.cloud_logging import (
4040
CloudLoggingExporter,
4141
)
42-
from opentelemetry.sdk._logs._internal import LogRecord
43-
from opentelemetry._logs.severity import SeverityNumber
4442
from opentelemetry.sdk.resources import Resource
4543
from opentelemetry._logs import set_logger_provider
4644
from opentelemetry.sdk._logs import LoggerProvider, LoggingHandler
@@ -57,7 +55,7 @@ Usage
5755
set_logger_provider(logger_provider)
5856
exporter = CloudLoggingExporter(default_log_name='my_log')
5957
logger_provider.add_log_record_processor(BatchLogRecordProcessor(exporter))
60-
handler = LoggingHandler(level=logging.NOTSET, logger_provider=logger_provider)
58+
handler = LoggingHandler(level=logging.ERROR, logger_provider=logger_provider)
6159
6260
# Attach OTLP handler to root logger
6361
logging.getLogger().addHandler(handler)
@@ -67,25 +65,7 @@ Usage
6765
# so telemetry is collected only for the application
6866
logger1 = logging.getLogger("myapp.area1")
6967
70-
logger1.debug(LogRecord(
71-
resource=Resource({}),
72-
timestamp=1736976310997977393,
73-
severity_number=SeverityNumber(20),
74-
attributes={
75-
"gen_ai.system": "openai",
76-
"event.name": "gen_ai.system.message",
77-
},
78-
body={
79-
"kvlistValue": {
80-
"values": [
81-
{
82-
"key": "content",
83-
"value": {"stringValue": "You're a helpful assistant."},
84-
}
85-
]
86-
}
87-
},
88-
))
68+
logger1.error({'structured_log_will_go_to_json_payload': 'value'}, extra={'this_will_go_to_LogEntry_labels_field': 'value'})
8969
9070
References
9171
----------

opentelemetry-exporter-gcp-logging/setup.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ where = src
3838
test =
3939

4040
[options.entry_points]
41-
opentelemetry_logging_exporter =
41+
opentelemetry_logs_exporter =
4242
gcp_logging = opentelemetry.exporter.cloud_logging:CloudLoggingExporter
4343
opentelemetry_environment_variables =
4444
gcp_logging = opentelemetry.exporter.cloud_logging.environment_variables

opentelemetry-exporter-gcp-logging/src/opentelemetry/exporter/cloud_logging/__init__.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,6 @@ def export(self, batch: Sequence[LogData]):
159159
log_entry.log_name = log_name
160160
if monitored_resource:
161161
log_entry.resource = monitored_resource
162-
attrs_map = {k: v for k, v in attributes.items()}
163162
log_entry.trace_sampled = bool(log_record.trace_flags)
164163
if log_record.trace_id:
165164
log_entry.trace = f"projects/{project_id}/traces/{format_trace_id(log_record.trace_id)}"
@@ -172,7 +171,7 @@ def export(self, batch: Sequence[LogData]):
172171
log_entry.severity = SEVERITY_MAPPING[ # type: ignore[assignment]
173172
log_record.severity_number.value # type: ignore[index]
174173
]
175-
log_entry.labels = {k: str(v) for k, v in attrs_map.items()}
174+
log_entry.labels = {k: str(v) for k, v in attributes.items()}
176175
if type(log_record.body) is dict:
177176
s = Struct()
178177
s.update(log_record.body)

0 commit comments

Comments
 (0)