Skip to content

Commit 250d26d

Browse files
committed
Fix e2e test and more samples to use GoogleCloudResourceDetector
1 parent d8b6eaa commit 250d26d

File tree

4 files changed

+6
-10
lines changed

4 files changed

+6
-10
lines changed

e2e-test-server/e2e_test_server/scenarios.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,7 @@
2222
from opentelemetry.propagators.cloud_trace_propagator import (
2323
CloudTraceFormatPropagator,
2424
)
25-
from opentelemetry.resourcedetector.gcp_resource_detector._detector import (
26-
GoogleCloudResourceDetector,
27-
)
25+
from opentelemetry.resourcedetector.gcp_resource_detector import GoogleCloudResourceDetector
2826
from opentelemetry.sdk.trace import TracerProvider
2927
from opentelemetry.sdk.trace.export import BatchSpanProcessor
3028
from opentelemetry.sdk.trace.sampling import ALWAYS_ON

samples/otlpmetric/example.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,7 @@
2424
from opentelemetry.exporter.otlp.proto.grpc.metric_exporter import (
2525
OTLPMetricExporter,
2626
)
27-
from opentelemetry.resourcedetector.gcp_resource_detector._detector import (
28-
GoogleCloudResourceDetector,
29-
)
27+
from opentelemetry.resourcedetector.gcp_resource_detector import GoogleCloudResourceDetector
3028
from opentelemetry.sdk.resources import SERVICE_NAME, Resource, get_aggregated_resources
3129
from opentelemetry.sdk.metrics import MeterProvider
3230
from opentelemetry.sdk.metrics.export import PeriodicExportingMetricReader

samples/otlptrace/example_grpc.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,17 @@
2424
from opentelemetry.exporter.otlp.proto.grpc.trace_exporter import (
2525
OTLPSpanExporter,
2626
)
27-
from opentelemetry.sdk.resources import SERVICE_NAME, Resource
2827
from opentelemetry.sdk.trace import TracerProvider
2928
from opentelemetry.sdk.trace.export import BatchSpanProcessor
29+
from opentelemetry.resourcedetector.gcp_resource_detector import GoogleCloudResourceDetector
3030

3131
"""
3232
This is a sample script that exports OTLP traces encoded as protobufs via gRPC.
3333
"""
3434

3535
credentials, _ = google.auth.default()
3636
request = google.auth.transport.requests.Request()
37-
resource = Resource.create(attributes={SERVICE_NAME: "otlp-gcp-grpc-sample"})
37+
resource = GoogleCloudResourceDetector().detect()
3838

3939
auth_metadata_plugin = AuthMetadataPlugin(credentials=credentials, request=request)
4040
channel_creds = grpc.composite_channel_credentials(

samples/otlptrace/example_http.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,14 @@
1919
from opentelemetry.exporter.otlp.proto.http.trace_exporter import (
2020
OTLPSpanExporter,
2121
)
22+
from opentelemetry.resourcedetector.gcp_resource_detector import GoogleCloudResourceDetector
2223
from google.auth.transport.requests import AuthorizedSession
23-
from opentelemetry.sdk.resources import SERVICE_NAME, Resource
2424
from opentelemetry.sdk.trace import TracerProvider
2525
from opentelemetry.sdk.trace.export import BatchSpanProcessor
2626

2727
credentials, _ = google.auth.default()
2828
trace_provider = TracerProvider(
29-
resource=Resource.create(attributes={SERVICE_NAME: "otlp-gcp-http-sample"})
29+
resource=GoogleCloudResourceDetector().detect()
3030
)
3131
processor = BatchSpanProcessor(
3232
OTLPSpanExporter(

0 commit comments

Comments
 (0)