Skip to content

Commit 87d7a89

Browse files
committed
Fix merge issues
1 parent 68f9472 commit 87d7a89

File tree

2 files changed

+3
-45
lines changed

2 files changed

+3
-45
lines changed

opentelemetry-exporter-gcp-logging/src/opentelemetry/exporter/cloud_logging/__init__.py

Lines changed: 1 addition & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,3 @@
1-
# Copyright 2025 Google LLC
2-
#
3-
# Licensed under the Apache License, Version 2.0 (the "License");
4-
# you may not use this file except in compliance with the License.
5-
# You may obtain a copy of the License at
6-
#
7-
# http://www.apache.org/licenses/LICENSE-2.0
8-
#
9-
# Unless required by applicable law or agreed to in writing, software
10-
# distributed under the License is distributed on an "AS IS" BASIS,
11-
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12-
# See the License for the specific language governing permissions and
13-
# limitations under the License.
14-
# Remove after this program no longer support Python 3.8.*
151
from __future__ import annotations
162
# Copyright 2025 Google LLC
173
#
@@ -29,16 +15,8 @@
2915
import datetime
3016
import logging
3117
import urllib.parse
32-
import logging
33-
import urllib.parse
3418
from typing import Optional, Sequence
3519

36-
import google.auth
37-
from google.api.monitored_resource_pb2 import MonitoredResource # type: ignore
38-
from google.cloud.logging_v2.services.logging_service_v2 import (
39-
LoggingServiceV2Client,
40-
)
41-
4220
import google.auth
4321
from google.api.monitored_resource_pb2 import MonitoredResource # type: ignore
4422
from google.cloud.logging_v2.services.logging_service_v2 import (
@@ -52,20 +30,13 @@
5230
from google.protobuf.struct_pb2 import Struct
5331
from google.protobuf.timestamp_pb2 import Timestamp
5432
from opentelemetry.exporter.cloud_logging.version import __version__
55-
from google.logging.type.log_severity_pb2 import LogSeverity # type: ignore
56-
from google.protobuf.struct_pb2 import Struct
57-
from google.protobuf.timestamp_pb2 import Timestamp
58-
from opentelemetry.exporter.cloud_logging.version import __version__
5933
from opentelemetry.resourcedetector.gcp_resource_detector._mapping import (
6034
get_monitored_resource,
6135
)
6236
from opentelemetry.sdk import version as opentelemetry_sdk_version
6337
from opentelemetry.sdk._logs import LogData
6438
from opentelemetry.sdk._logs.export import LogExporter
6539
from opentelemetry.sdk.resources import Resource
66-
from opentelemetry.sdk._logs import LogData
67-
from opentelemetry.sdk._logs.export import LogExporter
68-
from opentelemetry.sdk.resources import Resource
6940

7041
DEFAULT_MAX_ENTRY_SIZE = 256000 # 256 KB
7142
DEFAULT_MAX_REQUEST_SIZE = 10000000 # 10 MB
@@ -166,7 +137,6 @@ def export(self, batch: Sequence[LogData]):
166137
log_record.resource or Resource({})
167138
)
168139
# convert it to proto
169-
monitored_resource: Optional[MonitoredResource] = (
170140
monitored_resource: Optional[MonitoredResource] = (
171141
MonitoredResource(
172142
type=monitored_resource_data.type,
@@ -198,8 +168,6 @@ def export(self, batch: Sequence[LogData]):
198168
log_entry.trace_sampled = (
199169
log_record.trace_flags is not None
200170
and log_record.trace_flags.sampled
201-
log_record.trace_flags is not None
202-
and log_record.trace_flags.sampled
203171
)
204172
if TRACE_SAMPLED_ATTRIBUTE_KEY in attrs_map:
205173
log_entry.trace_sampled |= bool(
@@ -255,4 +223,4 @@ def _write_log_entries(self, log_entries: list[LogEntry]):
255223
self.client.write_log_entries(entries=batch)
256224

257225
def shutdown(self):
258-
pass
226+
pass

opentelemetry-exporter-gcp-logging/tests/test_cloud_logging.py

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -54,21 +54,17 @@ def test_invalid_otlp_entries_raise_warnings(caplog) -> None:
5454
no_default_logname = CloudLoggingExporter(
5555
project_id=PROJECT_ID, client=client
5656
)
57-
attrs = {str(i):"i" * 10000 for i in range(1000)}
58-
log_record = LogRecord(resource=Resource({}),
59-
attributes=attrs)
6057
no_default_logname.export(
6158
[
6259
LogData(
63-
log_record=log_record,
64-
log_record=log_record,
60+
log_record = LogRecord(resource=Resource({}),
61+
attributes={str(i):"i" * 10000 for i in range(1000)}),
6562
instrumentation_scope=InstrumentationScope("test"),
6663
)
6764
]
6865
)
6966
assert len(caplog.records) == 1
7067
assert "exceeds Cloud Logging's maximum limit of 256000.\n" in caplog.text
71-
assert "exceeds Cloud Logging's maximum limit of 256000.\n" in caplog.text
7268

7369

7470
def test_convert_otlp(
@@ -85,10 +81,6 @@ def test_convert_otlp(
8581
"gen_ai.system": "openai",
8682
"event.name": "gen_ai.system.message",
8783
},
88-
attributes={
89-
"gen_ai.system": "openai",
90-
"event.name": "gen_ai.system.message",
91-
},
9284
body={
9385
"kvlistValue": {
9486
"values": [
@@ -112,8 +104,6 @@ def test_convert_otlp(
112104
LogData(
113105
log_record=log_record,
114106
instrumentation_scope=InstrumentationScope("test"),
115-
log_record=log_record,
116-
instrumentation_scope=InstrumentationScope("test"),
117107
)
118108
]
119109
cloudloggingfake.exporter.export(log_data)

0 commit comments

Comments
 (0)