Skip to content

Commit bbe4308

Browse files
committed
respond to comments
1 parent f310e84 commit bbe4308

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

opentelemetry-resourcedetector-gcp/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,12 @@
22

33
## Unreleased
44

5-
Update opentelemetry-api/sdk dependencies to 1.3.
5+
- Update opentelemetry-api/sdk dependencies to 1.3.
6+
7+
- This is a breaking change which moves our official recource detector from `opentelemetry.resourcedetector.gcp_resource_detector._detector`
8+
into `opentelemetry.resourcedetector.gcp_resource_detector` and deletes the outdated duplicate resource detector
9+
which used to be there. Use `from opentelemetry.resourcedetector.gcp_resource_detector import GoogleCloudResourceDetector`
10+
to import it. See ([#389](https://github.com/GoogleCloudPlatform/opentelemetry-operations-python/pull/389)) for details.
611

712
## Version 1.9.0a0
813

opentelemetry-resourcedetector-gcp/README.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ Installation
2727
..
2828
2929
Usage
30-
------------
30+
-----
3131

3232
.. code:: python
3333
from opentelemetry.exporter.otlp.proto.http.trace_exporter import OTLPSpanExporter

opentelemetry-resourcedetector-gcp/src/opentelemetry/resourcedetector/gcp_resource_detector/__init__.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,3 +138,6 @@ def _make_resource(attrs: Mapping[str, AttributeValue]) -> Resource:
138138
**attrs,
139139
}
140140
)
141+
142+
143+
__all__ = ["GoogleCloudResourceDetector"]

0 commit comments

Comments
 (0)