Update Cloud Logging Exporter to handle bytes in dict body #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rations-python into fix_bytes
aabmass
reviewed
Jun 4, 2025
opentelemetry-exporter-gcp-logging/src/opentelemetry/exporter/cloud_logging/__init__.py
Outdated
Show resolved
Hide resolved
opentelemetry-exporter-gcp-logging/src/opentelemetry/exporter/cloud_logging/__init__.py
Outdated
Show resolved
Hide resolved
opentelemetry-exporter-gcp-logging/src/opentelemetry/exporter/cloud_logging/__init__.py
Outdated
Show resolved
Hide resolved
aabmass
approved these changes
Jun 4, 2025
opentelemetry-exporter-gcp-logging/src/opentelemetry/exporter/cloud_logging/__init__.py
Outdated
Show resolved
Hide resolved
opentelemetry-exporter-gcp-logging/src/opentelemetry/exporter/cloud_logging/__init__.py
Outdated
Show resolved
Hide resolved
opentelemetry-exporter-gcp-logging/src/opentelemetry/exporter/cloud_logging/__init__.py
Outdated
Show resolved
Hide resolved
opentelemetry-exporter-gcp-logging/src/opentelemetry/exporter/cloud_logging/__init__.py
Outdated
Show resolved
Hide resolved
opentelemetry-exporter-gcp-logging/src/opentelemetry/exporter/cloud_logging/__init__.py
Outdated
Show resolved
Hide resolved
…cloud_logging/__init__.py Co-authored-by: Aaron Abbott <[email protected]>
…cloud_logging/__init__.py Co-authored-by: Aaron Abbott <[email protected]>
Contributor
Author
|
Aaron importing AnyValue requires updating the otel api/sdk dependencies to 1.3 in dev_constraints.txt, which causes mypy to fail for the metrics exporter because it doesnt't handle the exponential histogram types yet. What's the best way to deal with this ? I could just remove that AnyValue import and put it back to Any import now that i've verified my code passes the type checker ? WDYT ? |
…rations-python into fix_bytes
Contributor
Author
|
I think this is ready to be merged.. Not sure why the e2e tests still are looking for v1.2 of the API/SDK, it seems they aren't using the version of the dev_constraints.txt file I modified in this PR? |
Contributor
Author
|
Nevermind figured it out.. Had to update the constraints.txt file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #406