migrate instrumentation sample to otlphttp #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanRussell
approved these changes
Dec 4, 2025
dashpole
force-pushed
the
instrumentation_otelhttp
branch
from
962775b to
42325d3
Compare
dashpole
force-pushed
the
instrumentation_otelhttp
branch
from
24046c7 to
f6fd7b8
Compare
Contributor
Author
|
@aabmass I'm having trouble getting to the bottom of this. It now passes for me locally, but still fails during the presubmit with the same generic error. When I was testing, the error was because the collector was not able to start. Maybe GOOGLE_CLOUD_PROJECT isn't set? |
Contributor
Author
|
Does it need to map PROJECT_ID to that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as GoogleCloudPlatform/opentelemetry-operations-java#425
Tested manually.