From 77aa2d785a8adfe3710eed7b250d100b6dc376f4 Mon Sep 17 00:00:00 2001 From: Mend Renovate Date: Sat, 20 Sep 2025 10:03:02 +0000 Subject: [PATCH 1/3] fix(deps): update dependency google/cloud-compute to v2 --- compute/firewall/composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compute/firewall/composer.json b/compute/firewall/composer.json index 64feccc5f3..5b16ac87ee 100644 --- a/compute/firewall/composer.json +++ b/compute/firewall/composer.json @@ -1,5 +1,5 @@ { "require": { - "google/cloud-compute": "^1.14" + "google/cloud-compute": "^2.0" } } From fc729e9a2de8a2f34e989d73f58584299c3c26a6 Mon Sep 17 00:00:00 2001 From: Brent Shaffer Date: Mon, 1 Dec 2025 15:09:22 -0800 Subject: [PATCH 2/3] remove gapic enums --- compute/firewall/src/create_firewall_rule.php | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/compute/firewall/src/create_firewall_rule.php b/compute/firewall/src/create_firewall_rule.php index de281f864e..b44720fedc 100644 --- a/compute/firewall/src/create_firewall_rule.php +++ b/compute/firewall/src/create_firewall_rule.php @@ -26,12 +26,6 @@ # [START compute_firewall_create] use Google\Cloud\Compute\V1\Allowed; use Google\Cloud\Compute\V1\Client\FirewallsClient; -use Google\Cloud\Compute\V1\Enums\Firewall\Direction; - -/** - * To correctly handle string enums in Cloud Compute library - * use constants defined in the Enums subfolder. - */ use Google\Cloud\Compute\V1\Firewall; use Google\Cloud\Compute\V1\InsertFirewallRequest; @@ -57,7 +51,7 @@ function create_firewall_rule(string $projectId, string $firewallRuleName, strin ->setPorts(['80', '443']); $firewallResource = (new Firewall()) ->setName($firewallRuleName) - ->setDirection(Direction::INGRESS) + ->setDirection(Firewall\Direction::INGRESS) ->setAllowed([$allowedPorts]) ->setSourceRanges(['0.0.0.0/0']) ->setTargetTags(['web']) From 4167cf6a6d64ec7ffe8416b43776bbcf3ae9af48 Mon Sep 17 00:00:00 2001 From: Brent Shaffer Date: Mon, 1 Dec 2025 16:26:08 -0800 Subject: [PATCH 3/3] fix phpstan for compute v2 --- compute/firewall/src/create_firewall_rule.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/compute/firewall/src/create_firewall_rule.php b/compute/firewall/src/create_firewall_rule.php index b44720fedc..a4b9550c3e 100644 --- a/compute/firewall/src/create_firewall_rule.php +++ b/compute/firewall/src/create_firewall_rule.php @@ -27,6 +27,7 @@ use Google\Cloud\Compute\V1\Allowed; use Google\Cloud\Compute\V1\Client\FirewallsClient; use Google\Cloud\Compute\V1\Firewall; +use Google\Cloud\Compute\V1\Firewall\Direction; use Google\Cloud\Compute\V1\InsertFirewallRequest; /** @@ -51,7 +52,7 @@ function create_firewall_rule(string $projectId, string $firewallRuleName, strin ->setPorts(['80', '443']); $firewallResource = (new Firewall()) ->setName($firewallRuleName) - ->setDirection(Firewall\Direction::INGRESS) + ->setDirection(Direction::name(Direction::INGRESS)) ->setAllowed([$allowedPorts]) ->setSourceRanges(['0.0.0.0/0']) ->setTargetTags(['web'])