fix: log error message when exception is caught (#12770)

* fix: log error message when exception is caught

* remove return since devrel tags are now moved inside the method to make the samples self runnable

Author: luongadam

managedkafka/snippets/clusters/create_cluster.py

@@ -33,7 +33,7 @@ def create_cluster(
         memory_bytes: The memory to provision for the cluster in bytes.
 
     Raises:
-        This method will raise the exception if the operation errors or
+        This method will raise the GoogleAPICallError exception if the operation errors or
         the timeout before the operation completes is reached.
     """
     # [START managedkafka_create_cluster]
@@ -71,6 +71,7 @@ def create_cluster(
         # The duration of this operation can vary considerably, typically taking 10-40 minutes.
         # We can set a timeout of 3000s (50 minutes).
         operation = client.create_cluster(request=request, timeout=3000)
+        print("Waiting for operation to finish...")
         response = operation.result()
         print("Created cluster:", response)
     except GoogleAPICallError:

managedkafka/snippets/clusters/delete_cluster.py

@@ -27,7 +27,7 @@ def delete_cluster(
         cluster_id: ID of the Kafka cluster.
 
     Raises:
-        This method will raise the exception if the operation errors or
+        This method will raise the GoogleAPICallError exception if the operation errors or
         the timeout before the operation completes is reached.
     """
     # [START managedkafka_delete_cluster]

managedkafka/snippets/clusters/get_cluster.py

@@ -25,8 +25,12 @@ def get_cluster(
         project_id: Google Cloud project ID.
         region: Cloud region.
         cluster_id: ID of the Kafka cluster.
+
+    Raises:
+        This method will raise the NotFound exception if the cluster is not found.
     """
     # [START managedkafka_get_cluster]
+    from google.api_core.exceptions import NotFound
     from google.cloud import managedkafka_v1
 
     # TODO(developer)
@@ -41,9 +45,10 @@ def get_cluster(
         name=cluster_path,
     )
 
-    cluster = client.get_cluster(request=request)
-    print("Got cluster:", cluster)
-
-    return cluster
+    try:
+        cluster = client.get_cluster(request=request)
+        print("Got cluster:", cluster)
+    except NotFound as e:
+        print(f"Failed to get cluster {cluster_id} with error: {e.message}")
 
     # [END managedkafka_get_cluster]

managedkafka/snippets/clusters/list_clusters.py

@@ -41,6 +41,4 @@ def list_clusters(
     for cluster in response:
         print("Got cluster:", cluster)
 
-    return [cluster.name for cluster in response]
-
     # [END managedkafka_list_clusters]

managedkafka/snippets/clusters/update_cluster.py

@@ -26,7 +26,7 @@ def update_cluster(
         memory_bytes: The memory to provision for the cluster in bytes.
 
     Raises:
-        This method will raise the exception if the operation errors or
+        This method will raise the GoogleAPICallError exception if the operation errors or
         the timeout before the operation completes is reached.
     """
     # [START managedkafka_update_cluster]

managedkafka/snippets/consumergroups/delete_consumer_group.py

@@ -29,7 +29,7 @@ def delete_consumer_group(
         consumer_group_id: ID of the Kafka consumer group.
 
     Raises:
-        This method will raise the exception if the consumer group is not found.
+        This method will raise the NotFound exception if the consumer group or the parent resource is not found.
     """
     # [START managedkafka_delete_consumergroup]
     from google.api_core.exceptions import NotFound
@@ -53,7 +53,7 @@ def delete_consumer_group(
     try:
         client.delete_consumer_group(request=request)
         print("Deleted consumer group")
-    except NotFound:
-        print(f"Consumer group {consumer_group_path} not found")
+    except NotFound as e:
+        print(f"Failed to delete consumer group {consumer_group_id} with error: {e.message}")
 
     # [END managedkafka_delete_consumergroup]

managedkafka/snippets/consumergroups/get_consumer_group.py

@@ -27,8 +27,12 @@ def get_consumer_group(
         region: Cloud region.
         cluster_id: ID of the Kafka cluster.
         consumer_group_id: ID of the Kafka consumer group.
+
+    Raises:
+        This method will raise the NotFound exception if the consumer group or the parent resource is not found.
     """
     # [START managedkafka_get_consumergroup]
+    from google.api_core.exceptions import NotFound
     from google.cloud import managedkafka_v1
 
     # TODO(developer)
@@ -46,9 +50,10 @@ def get_consumer_group(
         name=consumer_group_path,
     )
 
-    consumer_group = client.get_consumer_group(request=request)
-    print("Got consumer group:", consumer_group)
-
-    return consumer_group
+    try:
+        consumer_group = client.get_consumer_group(request=request)
+        print("Got consumer group:", consumer_group)
+    except NotFound as e:
+        print(f"Failed to get consumer group {consumer_group_id} with error: {e.message}")
 
     # [END managedkafka_get_consumergroup]

managedkafka/snippets/consumergroups/list_consumer_groups.py

@@ -44,6 +44,4 @@ def list_consumer_groups(
     for consumer_group in response:
         print("Got consumer group:", consumer_group)
 
-    return [consumer_group.name for consumer_group in response]
-
     # [END managedkafka_list_consumergroups]

managedkafka/snippets/consumergroups/update_consumer_group.py

@@ -33,7 +33,7 @@ def update_consumer_group(
         partition_offsets: Configuration of the topic, represented as a map of partition indexes to their offset value.
 
     Raises:
-        This method will raise the exception if the consumer group is not found.
+        This method will raise the NotFound exception if the consumer group or the parent resource is not found.
     """
     # [START managedkafka_update_consumergroup]
     from google.api_core.exceptions import NotFound
@@ -74,7 +74,7 @@ def update_consumer_group(
     try:
         response = client.update_consumer_group(request=request)
         print("Updated consumer group:", response)
-    except NotFound:
-        print(f"Consumer group {consumer_group.name} not found")
+    except NotFound as e:
+        print(f"Failed to update consumer group {consumer_group_id} with error: {e.message}")
 
     # [END managedkafka_update_consumergroup]

managedkafka/snippets/topics/create_topic.py

@@ -35,7 +35,7 @@ def create_topic(
         configs: Configuration of the topic.
 
     Raises:
-        This method will raise the exception if the topic already exists.
+        This method will raise the AlreadyExists exception if the topic already exists.
     """
     # [START managedkafka_create_topic]
     from google.api_core.exceptions import AlreadyExists
@@ -68,7 +68,7 @@ def create_topic(
     try:
         response = client.create_topic(request=request)
         print("Created topic:", response.name)
-    except AlreadyExists:
-        print(f"{topic.name} already exists")
+    except AlreadyExists as e:
+        print(f"Failed to create topic {topic.name} with error: {e.message}")
 
     # [END managedkafka_create_topic]