Skip to content

Commit f2c23cf

Browse files
committed
debug: ensure values use random suffix
1 parent 0269173 commit f2c23cf

File tree

1 file changed

+2
-24
lines changed

1 file changed

+2
-24
lines changed

run/django/e2e_test.py

Lines changed: 2 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -49,22 +49,11 @@
4949
POSTGRES_INSTANCE_FULL = f"{GOOGLE_CLOUD_PROJECT}:{REGION}:{POSTGRES_INSTANCE}"
5050
POSTGRES_INSTANCE_NAME = POSTGRES_INSTANCE
5151

52-
POSTGRES_DATABASE = f"django-database-{SUFFIX}"
53-
54-
CLOUD_STORAGE_BUCKET = f"{GOOGLE_CLOUD_PROJECT}-media-{SUFFIX}"
55-
CLOUD_RUN_JOB_NAME = f"django-migrate-{SUFFIX}"
56-
57-
POSTGRES_DATABASE = f"polls-{SUFFIX}"
58-
POSTGRES_USER = f"django-{SUFFIX}"
5952
POSTGRES_PASSWORD = uuid.uuid4().hex[:26]
6053

6154
ADMIN_NAME = "admin"
6255
ADMIN_PASSWORD = uuid.uuid4().hex[:26]
6356

64-
SECRET_SETTINGS_NAME = f"django_settings-{SUFFIX}"
65-
SECRET_PASSWORD_NAME = f"superuser_password-{SUFFIX}"
66-
67-
6857
@backoff.on_exception(backoff.expo, Exception, max_tries=3)
6958
def run_shell_cmd(args: list) -> subprocess.CompletedProcess:
7059
"""
@@ -98,18 +87,12 @@ def run_shell_cmd(args: list) -> subprocess.CompletedProcess:
9887
@pytest.fixture
9988
def deployed_service() -> str:
10089
substitutions = [
90+
f"_VERSION=${SUFFIX},"
10191
f"_SERVICE={SERVICE},"
10292
f"_REGION={REGION},"
103-
f"_STORAGE_BUCKET={CLOUD_STORAGE_BUCKET},"
104-
f"_DB_NAME={POSTGRES_DATABASE},"
105-
f"_DB_USER={POSTGRES_USER},"
10693
f"_DB_PASS={POSTGRES_PASSWORD},"
10794
f"_DB_INSTANCE={POSTGRES_INSTANCE_NAME},"
108-
f"_SECRET_SETTINGS_NAME={SECRET_SETTINGS_NAME},"
109-
f"_SECRET_PASSWORD_NAME={SECRET_PASSWORD_NAME},"
110-
f"_SECRET_PASSWORD_VALUE={ADMIN_PASSWORD},"
11195
f"_CLOUD_SQL_CONNECTION_NAME={POSTGRES_INSTANCE_FULL},"
112-
f"_CLOUD_RUN_JOB_NAME={CLOUD_RUN_JOB_NAME}"
11396
]
11497
if SAMPLE_VERSION:
11598
substitutions.append(f",_VERSION={SAMPLE_VERSION}")
@@ -133,15 +116,10 @@ def deployed_service() -> str:
133116
# Cleanup
134117

135118
substitutions = [
119+
f"_VERSION=${SUFFIX},"
136120
f"_SERVICE={SERVICE},"
137121
f"_REGION={REGION},"
138-
f"_DB_USER={POSTGRES_USER},"
139-
f"_DB_NAME={POSTGRES_DATABASE},"
140122
f"_DB_INSTANCE={POSTGRES_INSTANCE_NAME},"
141-
f"_SECRET_SETTINGS_NAME={SECRET_SETTINGS_NAME},"
142-
f"_SECRET_PASSWORD_NAME={SECRET_PASSWORD_NAME},"
143-
f"_STORAGE_BUCKET={CLOUD_STORAGE_BUCKET},"
144-
f"_CLOUD_RUN_JOB_NAME={CLOUD_RUN_JOB_NAME}"
145123
]
146124
if SAMPLE_VERSION:
147125
substitutions.append(f"_SAMPLE_VERSION={SAMPLE_VERSION}")

0 commit comments

Comments
 (0)