fix: (datastore) add imports to snippets #12601
Merged
+62
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
samples
daniel-sanche
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
gkevinzheng
reviewed
Sep 20, 2024
|
|
||
| def regional_endpoint(): | ||
| # [START datastore_regional_endpoints] | ||
| from google.cloud import datastore |
There was a problem hiding this comment.
Why is this the only sample that has this import?
There was a problem hiding this comment.
All the other ones also include the preamble, which imports datastore and creates the client
iennae
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
recognizing that this is a pre-existing issue where there are a bunch of samples in one file rather than one sample per file, (hopefully this can get refactored and fixed in the future) but also wanting to help unblock getting this fixed so that samples are copy pastable where they are showing up in c.g.c approving this.
riathakkar
pushed a commit
to riathakkar/python-docs-samples
that referenced
this pull request
Oct 8, 2024
* add imports to snippets * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * added missing import --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the datastore snippets are missing required imports. This change pulls the necessary imports into each sample in snippets.py