From 2ce3e2d02fbc9b44e1a6010f9d14c8c1ece0183a Mon Sep 17 00:00:00 2001 From: Emmanuel Alejandro Parada Licea Date: Tue, 18 Mar 2025 16:50:54 -0600 Subject: [PATCH 1/3] test(secretmanager): add test test_create_secret_without_ttl --- secretmanager/snippets/snippets_test.py | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/secretmanager/snippets/snippets_test.py b/secretmanager/snippets/snippets_test.py index a6ebef52ed2..790942a3e6f 100644 --- a/secretmanager/snippets/snippets_test.py +++ b/secretmanager/snippets/snippets_test.py @@ -232,13 +232,24 @@ def test_add_secret_version(secret: Tuple[str, str, str]) -> None: def test_create_secret( - client: secretmanager.SecretManagerServiceClient, project_id: str, secret_id: str, ttl: Optional[str], ) -> None: secret = create_secret(project_id, secret_id, ttl) + + assert secret_id in secret.name + assert secret.expire_time + + +def test_create_secret_without_ttl( + project_id: str, + secret_id: str, +) -> None: + secret = create_secret(project_id, secret_id, None) + assert secret_id in secret.name + assert not secret.expire_time def test_create_secret_with_user_managed_replication( From ec5dc4cd5b43727455fb9ef2d1a7e29d3087e9ca Mon Sep 17 00:00:00 2001 From: Emmanuel Alejandro Parada Licea Date: Mon, 24 Mar 2025 10:28:52 -0600 Subject: [PATCH 2/3] test(secretmanager): make a simple change to trigger GitHub Actions again --- secretmanager/snippets/requirements.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/secretmanager/snippets/requirements.txt b/secretmanager/snippets/requirements.txt index 42fb31e68c4..3e8979ffb21 100644 --- a/secretmanager/snippets/requirements.txt +++ b/secretmanager/snippets/requirements.txt @@ -1,3 +1,4 @@ google-cloud-secret-manager==2.21.1 google-crc32c==1.6.0 protobuf==5.29.3 + From c4f8d7ce0b67c87b821adcd13b6df24ba701e56a Mon Sep 17 00:00:00 2001 From: Emmanuel Alejandro Parada Licea Date: Mon, 24 Mar 2025 10:29:18 -0600 Subject: [PATCH 3/3] test(secretmanager): revert previous commit --- secretmanager/snippets/requirements.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/secretmanager/snippets/requirements.txt b/secretmanager/snippets/requirements.txt index 3e8979ffb21..42fb31e68c4 100644 --- a/secretmanager/snippets/requirements.txt +++ b/secretmanager/snippets/requirements.txt @@ -1,4 +1,3 @@ google-cloud-secret-manager==2.21.1 google-crc32c==1.6.0 protobuf==5.29.3 -