Skip to content

Commit 86ac944

Browse files
author
Frank Natividad
committed
Added wait_until to Ruby Logger spec
Also cleaned up Logging query
1 parent efb53af commit 86ac944

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

logging/spec/sample_spec.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -209,8 +209,7 @@ def cleanup!
209209
current_time = Time.now.to_f
210210

211211
entries = @logging.entries(
212-
filter: %{logName = "projects/#{@project_id}/logs/my_application_log"},
213-
order: "timestamp desc"
212+
filter: %Q{logName="projects/#{@project_id}/logs/my_application_log"},
214213
)
215214
entry = entries.detect { |e| e.payload.include? "time #{current_time}" }
216215
expect(entry).to be nil
@@ -240,15 +239,16 @@ def cleanup!
240239
end
241240

242241
write_log_entry_using_ruby_logger
242+
entries = []
243243

244244
# Wait for entry to be queryable
245245
wait_until do
246-
my_application_log_entries.any? do |e|
246+
entries = my_application_log_entries
247+
entries.any? do |e|
247248
e.payload == "Log message - current time #{current_time}"
248249
end
249250
end
250251

251-
entries = my_application_log_entries
252252
entry = entries.detect { |e| e.payload.include? "time #{current_time}" }
253253
expect(entry).not_to be nil
254254
expect(entry.payload).to eq "Log message - current time #{current_time}"

0 commit comments

Comments
 (0)