Skip to content

Commit ade422e

Browse files
author
Frank Natividad
committed
Loggging spec cleanup code and query's
1 parent a710460 commit ade422e

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

logging/spec/sample_spec.rb

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@ def my_application_log_name
3535
# Returns entries logged to "my_application_log" in the test project
3636
def my_application_log_entries
3737
@logging.entries(
38-
filter: %{logName = "#{my_application_log_name}"},
39-
order: "timestamp desc"
38+
filter: %Q{logName="#{my_application_log_name}"}
4039
)
4140
end
4241

@@ -196,9 +195,7 @@ def cleanup!
196195
expect(entry).not_to be nil
197196
expect(entry.payload).to eq "Log message - current time #{current_time}"
198197
expect(entry.severity).to eq :NOTICE
199-
expect(entry.log_name).to eq(
200-
"projects/#{@project_id}/logs/my_application_log"
201-
)
198+
expect(entry.log_name).to eq my_application_log_name
202199
end
203200

204201
it "can delete log" do
@@ -209,7 +206,7 @@ def cleanup!
209206
current_time = Time.now.to_f
210207

211208
entries = @logging.entries(
212-
filter: %Q{logName="projects/#{@project_id}/logs/my_application_log"}
209+
filter: %Q{logName="#{my_application_log_name}"}
213210
)
214211
entry = entries.detect { |e| e.payload.include? "time #{current_time}" }
215212
expect(entry).to be nil
@@ -253,8 +250,6 @@ def cleanup!
253250
expect(entry).not_to be nil
254251
expect(entry.payload).to eq "Log message - current time #{current_time}"
255252
expect(entry.severity).to eq :INFO
256-
expect(entry.log_name).to eq(
257-
"projects/#{@project_id}/logs/my_application_log"
258-
)
253+
expect(entry.log_name).to eq my_application_log_name
259254
end
260255
end

0 commit comments

Comments
 (0)