YAML config parsing issue

[aryantaheri]

YAML examples aren't parsed properly and no tests are picked up.

Steps to reproduce:

$ cd plugins/samples/add_request_header/
$ go mod init go-plugin
$ go mod tidy
$ mkdir -p build && env GOOS=wasip1 GOARCH=wasm go build -buildmode=c-shared -o build/plugin.wasm plugin.go
$ docker run -it -v $(pwd):/mnt us-docker.pkg.dev/service-extensions-samples/plugins/wasm-tester:main --yaml /mnt/tests.yaml  --plugin /mnt/build/plugin.wasm
[==========] Running 0 tests from 0 test suites.
[==========] 0 tests from 0 test suites ran. (0 ms total)
[  PASSED  ] 0 tests.

There seems to be some differences between the expected keys and keys in the example such as test vs tests, result.has_header list vs map expectation.

The proto tests are working as expected.

docker run -it -v $(pwd):/mnt     us-docker.pkg.dev/service-extensions-samples/plugins/wasm-tester:main     --proto /mnt/tests.textpb     --plugin /mnt/build/plugin.wasm
[==========] Running 4 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 4 tests from Test_v8
[ RUN      ] Test_v8.AddsRequestHeader
[       OK ] Test_v8.AddsRequestHeader (134 ms)
[ RUN      ] Test_v8.UpdatesRequestHeader
[       OK ] Test_v8.UpdatesRequestHeader (125 ms)
[ RUN      ] Test_v8.RequestAndResponse
[       OK ] Test_v8.RequestAndResponse (122 ms)
[ RUN      ] Test_v8.CaseInsensitiveUpdates
[       OK ] Test_v8.CaseInsensitiveUpdates (115 ms)
[----------] 4 tests from Test_v8 (497 ms total)

[----------] Global test environment tear-down
[==========] 4 tests from 1 test suite ran. (497 ms total)
[  PASSED  ] 4 tests.
[sic]

[martijneken]

Thanks for filing this! I've been meaning to replace our tester YAML support anyway. It's very much hardcoded here: https://github.com/GoogleCloudPlatform/service-extensions/blob/main/plugins/test/yaml_proto_converter.cpp

I think a more elegant strategy would be a real conversion: YAML -> Protobuf::Value -> JSON -> Protobuf::Message

Check out this trick in action in Envoy: https://github.com/envoyproxy/envoy/blob/13338a5b0e67574b66a3f9c5d03d7fe4811cb020/source/common/protobuf/yaml_utility.cc#L178-L187

Want to give it a shot?

[bkane-msft]

Hello, I think is also affecting us. I'm able to write nonsensical asserts like this and the tests still pass.

- name: no_cookie_no_header_set
  request_headers:
    input:
      headers:
      - key: :path
        value: /feed
      - key: :method
        value: GET
    result:
      has_header:
        key: X-Edge-Ext-Backend
        value: shouldbesomething
      no_header:
        key: X-Edge-Ext-Backend

[bkane-msft]

Fortunately, Claude was able to rewrite my YAML tests into textproto in a few minutes