Skip to content

Commit 073a30f

Browse files
dependabot[bot]JoeWang1127
dependabot[bot]
and
JoeWang1127
authored
deps: bump com.puppycrawl.tools:checkstyle from 10.0 to 10.21.0 (#3417)
* deps: bump com.puppycrawl.tools:checkstyle from 10.0 to 10.21.0 Bumps [com.puppycrawl.tools:checkstyle](https://github.com/checkstyle/checkstyle) from 10.0 to 10.21.0. - [Release notes](https://github.com/checkstyle/checkstyle/releases) - [Commits](checkstyle/checkstyle@checkstyle-10.0...checkstyle-10.21.0) --- updated-dependencies: - dependency-name: com.puppycrawl.tools:checkstyle dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * reformat --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joe Wang <joewa@google.com>
1 parent 998399d commit 073a30f

File tree

12 files changed

+42
-42
lines changed

12 files changed

+42
-42
lines changed

‎pom.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
<maven.compiler.target>17</maven.compiler.target>
5858
<nexus-staging-plugin.version>1.7.0</nexus-staging-plugin.version>
5959
<maven-checkstyle-plugin.version>3.5.0</maven-checkstyle-plugin.version>
60-
<checkstyle-rules.version>10.0</checkstyle-rules.version>
60+
<checkstyle-rules.version>10.21.0</checkstyle-rules.version>
6161
<asciidoctor-maven-plugin.version>2.0.0</asciidoctor-maven-plugin.version>
6262
<native-maven-plugin.version>0.10.3</native-maven-plugin.version>
6363
<errorprone.version>2.34.0</errorprone.version>

‎spring-cloud-gcp-autoconfigure/src/test/java/com/google/cloud/spring/autoconfigure/pubsub/GcpPubSubAutoConfigurationTests.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ void retryableCodes_empty() {
167167
}
168168

169169
@Test
170-
void retryableCodes_Internal() {
170+
void retryableCodesInternal() {
171171
contextRunner
172172
.withPropertyValues("spring.cloud.gcp.pubsub.subscriber.retryableCodes=INTERNAL")
173173
.run(

‎spring-cloud-gcp-autoconfigure/src/test/java/com/google/cloud/spring/autoconfigure/pubsub/health/PubSubHealthIndicatorTests.java‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -115,40 +115,40 @@ void randomSubscription_unexpectedErrorCode() throws Exception {
115115
}
116116

117117
@Test
118-
void randomSubscription_NotApiExcpetion() throws Exception {
118+
void randomSubscriptionNotApiExcpetion() throws Exception {
119119
ExecutionException e = new ExecutionException("Exception", new IllegalArgumentException());
120120
testHealth(e, null, Status.DOWN);
121121
}
122122

123123
@ParameterizedTest
124124
@ValueSource(strings = {"NOT_FOUND", "PERMISSION_DENIED"})
125-
void customSubscription_ApiException(String code) throws Exception {
125+
void customSubscriptionApiException(String code) throws Exception {
126126
Exception e =
127127
new ExecutionException(
128128
new ApiException(null, GrpcStatusCode.of(io.grpc.Status.Code.valueOf(code)), false));
129129
testHealth(e, "testSubscription", Status.DOWN);
130130
}
131131

132132
@Test
133-
void customSubscription_ExecutionException_NotApiException() throws Exception {
133+
void customSubscriptionExecutionExceptionNotApiException() throws Exception {
134134
ExecutionException e = new ExecutionException("Exception", new IllegalArgumentException());
135135
testHealth(e, "testSubscription", Status.DOWN);
136136
}
137137

138138
@Test
139-
void customSubscription_InterruptedException() throws Exception {
139+
void customSubscriptionInterruptedException() throws Exception {
140140
Exception e = new InterruptedException("Interrupted");
141141
testHealth(e, "testSubscription", Status.UNKNOWN);
142142
}
143143

144144
@Test
145-
void customSubscription_TimeoutException() throws Exception {
145+
void customSubscriptionTimeoutException() throws Exception {
146146
Exception e = new TimeoutException("Timed out waiting for result");
147147
testHealth(e, "testSubscription", Status.UNKNOWN);
148148
}
149149

150150
@Test
151-
void customSubscription_RuntimeException() throws Exception {
151+
void customSubscriptionRuntimeException() throws Exception {
152152
Exception e = new RuntimeException("Runtime error");
153153
testHealth(e, "testSubscription", Status.DOWN);
154154
}

‎spring-cloud-gcp-autoconfigure/src/test/java/com/google/cloud/spring/autoconfigure/trace/pubsub/TracePubSubBeanPostProcessorTest.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ final class TracePubSubBeanPostProcessorTest {
3737
new TracePubSubBeanPostProcessor(mockBeanFactory);
3838

3939
@Test
40-
void test_postProcessBeforeInitialization_SubscriberFactory() {
40+
void test_postProcessBeforeInitializationSubscriberFactory() {
4141
SubscriberFactory mockSubscriberFactory = mock(SubscriberFactory.class);
4242

4343
Object result =
@@ -48,7 +48,7 @@ void test_postProcessBeforeInitialization_SubscriberFactory() {
4848
}
4949

5050
@Test
51-
void test_postProcessBeforeInitialization_Other() {
51+
void test_postProcessBeforeInitializationOther() {
5252
PubSubTemplate mockOther = mock(PubSubTemplate.class);
5353

5454
Object result =

‎spring-cloud-gcp-bigquery/src/test/java/com/google/cloud/spring/bigquery/integration/outbound/BigQueryFileMessageHandlerTests.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ void testHandleMessage_sync() {
122122
}
123123

124124
@Test
125-
void testHandleMessage_ThrowsExecutionExceptionTest()
125+
void testHandleMessageThrowsExecutionExceptionTest()
126126
throws ExecutionException, InterruptedException, TimeoutException {
127127
CompletableFuture<Job> mockCompletableFuture = mock(CompletableFuture.class);
128128
when(bigQueryTemplate.writeDataToTable(any(), any(), any(), any())).thenReturn(
@@ -142,7 +142,7 @@ void testHandleMessage_ThrowsExecutionExceptionTest()
142142
}
143143

144144
@Test
145-
void testHandleMessage_ThrowsInterruptedExceptionTest()
145+
void testHandleMessageThrowsInterruptedExceptionTest()
146146
throws ExecutionException, InterruptedException, TimeoutException {
147147
CompletableFuture<Job> mockCompletableFuture = mock(CompletableFuture.class);
148148
when(bigQueryTemplate.writeDataToTable(any(), any(), any(), any())).thenReturn(

‎spring-cloud-gcp-data-datastore/src/test/java/com/google/cloud/spring/data/datastore/core/util/KeyUtilTest.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
class KeyUtilTest {
2626

2727
@Test
28-
void testRemoveAncestors_NamedKeys() {
28+
void testRemoveAncestorsNamedKeys() {
2929
Key namedKey =
3030
Key.newBuilder("project", "person", "Smith")
3131
.addAncestor(PathElement.of("person", "GrandParent"))
@@ -37,7 +37,7 @@ void testRemoveAncestors_NamedKeys() {
3737
}
3838

3939
@Test
40-
void testRemoveAncestors_IdKeys() {
40+
void testRemoveAncestorsIdKeys() {
4141
Key idKey =
4242
Key.newBuilder("project", "person", 46L)
4343
.addAncestor(PathElement.of("person", 22L))

‎spring-cloud-gcp-data-spanner/src/test/java/com/google/cloud/spring/data/spanner/repository/it/SpannerRepositoryIntegrationTests.java‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ void queryMethodsTest_updateActionTradeById() {
148148
}
149149

150150
@Test
151-
void queryMethodsTest_BoundParameters() {
151+
void queryMethodsTestBoundParameters() {
152152
insertTrades("trader1", "BUY", 3);
153153
insertTrades("trader1", "SELL", 2);
154154
insertTrades("trader2", "SELL", 3);
@@ -251,7 +251,7 @@ void queryMethodsTest_readsAndCounts() {
251251
}
252252

253253
@Test
254-
void queryMethodsTest_Trader2() {
254+
void queryMethodsTestTrader2() {
255255
List<Trade> trader2Trades = insertTrades("trader2", "SELL", 3);
256256

257257
List<Trade> trader2TradesRetrieved = this.tradeRepository.findByTraderId("trader2");
@@ -340,7 +340,7 @@ void queryMethodsTest_sortingAndPaging() {
340340
}
341341

342342
@Test
343-
void queryMethodsTest_CustomSort() {
343+
void queryMethodsTestCustomSort() {
344344
insertTrades("trader1", "BUY", 3);
345345
insertTrades("trader1", "SELL", 2);
346346
insertTrades("trader2", "SELL", 3);
@@ -354,7 +354,7 @@ void queryMethodsTest_CustomSort() {
354354
}
355355

356356
@Test
357-
void queryMethodsTest_Wildcards() {
357+
void queryMethodsTestWildcards() {
358358
insertTrades("trader1", "BUY", 3);
359359

360360
this.tradeRepository
@@ -376,7 +376,7 @@ void queryMethodsTest_Wildcards() {
376376
}
377377

378378
@Test
379-
void queryMethodsTest_NullColumns() {
379+
void queryMethodsTestNullColumns() {
380380
insertTrades("trader1", "BUY", 3);
381381

382382
Trade someTrade = this.tradeRepository.findBySymbolContains("ABCD").get(0);
@@ -394,7 +394,7 @@ void queryMethodsTest_NullColumns() {
394394
}
395395

396396
@Test
397-
void queryMethodsTest_ParentChildOperations() {
397+
void queryMethodsTestParentChildOperations() {
398398
insertTrades("trader1", "BUY", 3);
399399

400400
Trade someTrade = this.tradeRepository.findBySymbolContains("ABCD").get(0);
@@ -464,7 +464,7 @@ void queryMethodsTest_ParentChildOperations() {
464464
}
465465

466466
@Test
467-
void queryMethodsTest_EagerFetch() {
467+
void queryMethodsTestEagerFetch() {
468468
final Trade aTrade = Trade.makeTrade("trader1", 0, 0);
469469
aTrade.setAction("BUY");
470470
aTrade.setSymbol("ABCD");
@@ -480,7 +480,7 @@ void queryMethodsTest_EagerFetch() {
480480
}
481481

482482
@Test
483-
void queryMethodsTest_SoftDelete() {
483+
void queryMethodsTestSoftDelete() {
484484
Trade someTrade = insertTrade("trader1", "BUY", 1);
485485
SubTrade subTrade1 =
486486
new SubTrade(someTrade.getTradeDetail().getId(), someTrade.getTraderId(), "subTrade1");

‎spring-cloud-gcp-pubsub/src/test/java/com/google/cloud/spring/pubsub/core/PubSubTemplateTests.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ void testPublish() throws ExecutionException, InterruptedException {
103103
}
104104

105105
@Test
106-
void testPublish_String() {
106+
void testPublishString() {
107107
when(this.mockPublisherFactory.createPublisher("testTopic")).thenReturn(this.mockPublisher);
108108
when(this.mockPublisher.publish(isA(PubsubMessage.class))).thenReturn(this.settableApiFuture);
109109
this.pubSubTemplate.publish("testTopic", "testPayload");
@@ -112,7 +112,7 @@ void testPublish_String() {
112112
}
113113

114114
@Test
115-
void testPublish_Bytes() {
115+
void testPublishBytes() {
116116
when(this.mockPublisherFactory.createPublisher("testTopic")).thenReturn(this.mockPublisher);
117117
when(this.mockPublisher.publish(isA(PubsubMessage.class))).thenReturn(this.settableApiFuture);
118118
this.pubSubTemplate.publish("testTopic", "testPayload".getBytes());
@@ -121,7 +121,7 @@ void testPublish_Bytes() {
121121
}
122122

123123
@Test
124-
void testPublish_Object() throws IOException {
124+
void testPublishObject() {
125125
AllowedPayload allowedPayload = new AllowedPayload();
126126
allowedPayload.name = "allowed";
127127
allowedPayload.value = 12345;

‎spring-cloud-gcp-pubsub/src/test/java/com/google/cloud/spring/pubsub/core/subscriber/PubSubSubscriberTemplateTests.java‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ void setUp() throws ExecutionException, InterruptedException {
199199
}
200200

201201
@Test
202-
void testSubscribe_AndManualAck()
202+
void testSubscribeAndManualAck()
203203
throws InterruptedException, ExecutionException, TimeoutException {
204204
this.pubSubSubscriberTemplate.subscribe("sub1", this.consumer);
205205

@@ -223,7 +223,7 @@ void testSubscribe_AndManualAck()
223223
}
224224

225225
@Test
226-
void testSubscribe_AndManualNack()
226+
void testSubscribeAndManualNack()
227227
throws InterruptedException, ExecutionException, TimeoutException {
228228
this.pubSubSubscriberTemplate.subscribe("sub1", this.consumer);
229229

@@ -247,7 +247,7 @@ void testSubscribe_AndManualNack()
247247
}
248248

249249
@Test
250-
void testSubscribeAndConvert_AndManualAck()
250+
void testSubscribeAndConvertAndManualAck()
251251
throws InterruptedException, ExecutionException, TimeoutException {
252252
this.pubSubSubscriberTemplate.subscribeAndConvert(
253253
"sub1", this.convertedConsumer, Boolean.class);
@@ -279,7 +279,7 @@ void testSubscribeAndConvert_AndManualAck()
279279
}
280280

281281
@Test
282-
void testSubscribeAndConvert_AndManualNack()
282+
void testSubscribeAndConvertAndManualNack()
283283
throws InterruptedException, ExecutionException, TimeoutException {
284284
this.pubSubSubscriberTemplate.subscribeAndConvert(
285285
"sub1", this.convertedConsumer, Boolean.class);
@@ -325,7 +325,7 @@ void destroyingBeanClosesSubscriberStub() {
325325
}
326326

327327
@Test
328-
void testPull_AndManualAck()
328+
void testPullAndManualAck()
329329
throws InterruptedException, ExecutionException, TimeoutException {
330330

331331
List<AcknowledgeablePubsubMessage> result = this.pubSubSubscriberTemplate.pull("sub2", 1, true);
@@ -353,7 +353,7 @@ void testPull_AndManualAck()
353353
}
354354

355355
@Test
356-
void testPull_AndManualNack()
356+
void testPullAndManualNack()
357357
throws InterruptedException, ExecutionException, TimeoutException {
358358
List<AcknowledgeablePubsubMessage> result = this.pubSubSubscriberTemplate.pull("sub2", 1, true);
359359

@@ -380,7 +380,7 @@ void testPull_AndManualNack()
380380
}
381381

382382
@Test
383-
void testPull_AndManualMultiSubscriptionAck()
383+
void testPullAndManualMultiSubscriptionAck()
384384
throws InterruptedException, ExecutionException, TimeoutException {
385385
ExecutorService mockExecutor = Mockito.mock(ExecutorService.class);
386386
this.pubSubSubscriberTemplate.setAckExecutor(mockExecutor);
@@ -409,7 +409,7 @@ void testPull_AndManualMultiSubscriptionAck()
409409
}
410410

411411
@Test
412-
void testPullAsync_AndManualAck()
412+
void testPullAsyncAndManualAck()
413413
throws InterruptedException, ExecutionException, TimeoutException {
414414

415415
CompletableFuture<List<AcknowledgeablePubsubMessage>> asyncResult =
@@ -455,7 +455,7 @@ void testPullAndAck() {
455455
}
456456

457457
@Test
458-
void testPullAndAck_NoMessages() {
458+
void testPullAndAckNoMessages() {
459459
when(this.pullCallable.call(any(PullRequest.class)))
460460
.thenReturn(PullResponse.newBuilder().build());
461461

@@ -484,7 +484,7 @@ void testPullAndAckAsync()
484484
}
485485

486486
@Test
487-
void testPullAndAckAsync_NoMessages()
487+
void testPullAndAckAsyncNoMessages()
488488
throws InterruptedException, ExecutionException, TimeoutException {
489489
when(this.pullApiFuture.get()).thenReturn(PullResponse.newBuilder().build());
490490

@@ -542,7 +542,7 @@ void testPullNext() {
542542
}
543543

544544
@Test
545-
void testPullNext_NoMessages() {
545+
void testPullNextNoMessages() {
546546
when(this.pullCallable.call(any(PullRequest.class)))
547547
.thenReturn(PullResponse.newBuilder().build());
548548

@@ -570,7 +570,7 @@ void testPullNextAsync()
570570
}
571571

572572
@Test
573-
void testPullNextAsync_NoMessages()
573+
void testPullNextAsyncNoMessages()
574574
throws InterruptedException, ExecutionException, TimeoutException {
575575
when(this.pullApiFuture.get()).thenReturn(PullResponse.newBuilder().build());
576576

‎spring-cloud-gcp-pubsub/src/test/java/com/google/cloud/spring/pubsub/integration/inbound/PubSubInboundChannelAdapterTests.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ void testAckModeAutoAck_neitherAcksNorNacksWhenMessageProcessingFails(CapturedOu
187187
}
188188

189189
@Test
190-
void testSetHealthRegistry_Success() {
190+
void testSetHealthRegistrySuccess() {
191191

192192
setupSubscribeAndConvert();
193193
HealthTrackerRegistry healthTrackerRegistry = mock(HealthTrackerRegistry.class);

0 commit comments

Comments
 (0)