chore: cleanup release scripts to prepare for migration to internal (#3718)

* chore: cleanup release scripts to prepare for migration to internal

b/308610909

* missed one

* fix promote.sh

* Maven Super POM already includes attach-sources

It's under the release-profile activated by -DperformRelease. See: https://maven.apache.org/ref/3.9.9/maven-model-builder/super-pom.html

Author: meltsufin

.github/workflows/unitTests.yaml

@@ -117,7 +117,7 @@ jobs:
           ./mvnw \
             --batch-mode \
             --no-transfer-progress \
-            -Drelease=true \
+            -DperformRelease=true \
             -DskipTests \
             -Dgpg.skip \
             -Dcheckstyle.skip \

.kokoro/drop.sh

@@ -38,6 +38,6 @@ create_settings_xml_file $MAVEN_SETTINGS_FILE
   --batch-mode \
   --settings  ${MAVEN_SETTINGS_FILE} \
   -DstagingRepositoryId=${STAGING_REPOSITORY_ID} \
-  -Drelease=true
+  -DperformRelease=true
 
 popd

.kokoro/promote.sh

@@ -38,7 +38,6 @@ create_settings_xml_file $MAVEN_SETTINGS_FILE
   --batch-mode \
   --settings ${MAVEN_SETTINGS_FILE} \
   -DstagingRepositoryId=${STAGING_REPOSITORY_ID} \
-  -Drelease=true \
-  --activate-profiles skip-unreleased-modules
+  -DperformRelease=true \
 
 popd

.kokoro/publish_javadoc.sh

@@ -16,7 +16,7 @@ PROJECT_VERSION=$(grep "^spring-cloud-gcp:" "./versions.txt" | cut -d: -f3)
 python3 -m pip install --require-hashes -r .kokoro/requirements.txt
 
 # Build the javadocs
-mvn clean javadoc:aggregate -Drelease=true
+mvn clean javadoc:aggregate -DperformRelease=true
 
 # Move into generated docs directory
 pushd target/reports/apidocs/

.kokoro/stage.sh

@@ -43,17 +43,15 @@ export MAVEN_OPTS="--add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.
   -Dgpg.executable=gpg \
   -Dgpg.passphrase=${GPG_PASSPHRASE} \
   -Dgpg.homedir=${GPG_HOMEDIR} \
-  -Drelease=true \
-  --activate-profiles skip-unreleased-modules
+  -DperformRelease=true \
 
 # promote release
 if [[ -n "${AUTORELEASE_PR}" ]]
 then
     ./mvnw nexus-staging:release \
     --batch-mode \
     --settings ${MAVEN_SETTINGS_FILE} \
-    -Drelease=true \
-    --activate-profiles skip-unreleased-modules
+    -DperformRelease=true \
 fi
 
 popd

pom.xml

@@ -448,7 +448,7 @@
 			<id>default</id>
 			<activation>
 				<property>
-					<name>!release</name>
+					<name>!performRelease</name>
 				</property>
 			</activation>
 			<modules>
@@ -703,7 +703,7 @@
 			<id>release</id>
 			<activation>
 				<property>
-					<name>release</name>
+					<name>performRelease</name>
 				</property>
 			</activation>
 			<modules>
@@ -815,19 +815,6 @@
 							</excludePackageNames>
 						</configuration>
 					</plugin>
-					<plugin>
-						<groupId>org.apache.maven.plugins</groupId>
-						<artifactId>maven-source-plugin</artifactId>
-						<executions>
-							<execution>
-								<id>attach-sources</id>
-								<goals>
-									<goal>jar</goal>
-								</goals>
-								<phase>package</phase>
-							</execution>
-						</executions>
-					</plugin>
 					<plugin>
 						<groupId>org.codehaus.mojo</groupId>
 						<artifactId>flatten-maven-plugin</artifactId>

spring-cloud-gcp-dependencies/pom.xml

@@ -318,7 +318,7 @@
 			<id>release</id>
 			<activation>
 				<property>
-					<name>release</name>
+					<name>performRelease</name>
 				</property>
 			</activation>
 			<build>

spring-cloud-gcp-starters/spring-cloud-gcp-starter-config/pom.xml

@@ -36,6 +36,11 @@
 		<!-- skip for GA releases to Maven Central -->
 		<profile>
 			<id>skip-unreleased-modules</id>
+			<activation>
+				<property>
+					<name>performRelease</name>
+				</property>
+			</activation>
 			<build>
 				<plugins>
 					<plugin>