Skip to content

Commit 92113ab

Browse files
pawan1210q2w
andauthored
chore: updated display metadata (#374)
Co-authored-by: abhishek kumar tiwari <[email protected]>
1 parent 2004e37 commit 92113ab

File tree

8 files changed

+45
-31
lines changed

8 files changed

+45
-31
lines changed

build/int.cloudbuild.yaml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -36,23 +36,23 @@ steps:
3636
- 'TF_VAR_org_id=$_ORG_ID'
3737
- 'TF_VAR_folder_id=$_FOLDER_ID'
3838
- 'TF_VAR_billing_account=$_BILLING_ACCOUNT'
39-
- id: create standalone
40-
name: 'gcr.io/cloud-foundation-cicd/$_DOCKER_IMAGE_DEVELOPER_TOOLS:$_DOCKER_TAG_VERSION_DEVELOPER_TOOLS'
41-
args: ['/bin/bash', '-c', 'source /usr/local/bin/task_helper_functions.sh && source_test_env && init_credentials && cft test run TestSecureCloudRunStandalone --test-dir /workspace/test/integration --verbose']
42-
env:
43-
- 'TF_VAR_org_id=$_ORG_ID'
44-
- 'TF_VAR_parent_folder_id=$_FOLDER_ID'
45-
- 'TF_VAR_billing_account=$_BILLING_ACCOUNT'
46-
- 'TF_VAR_domain=test.blueprints.joonix.net'
47-
- 'TF_VAR_serverless_folder_suffix=$SHORT_SHA'
48-
- 'TF_VAR_create_access_context_manager_access_policy=false'
49-
waitFor:
50-
- prepare
39+
# - id: create standalone
40+
# name: 'gcr.io/cloud-foundation-cicd/$_DOCKER_IMAGE_DEVELOPER_TOOLS:$_DOCKER_TAG_VERSION_DEVELOPER_TOOLS'
41+
# args: ['/bin/bash', '-c', 'source /usr/local/bin/task_helper_functions.sh && source_test_env && init_credentials && cft test run TestSecureCloudRunStandalone --test-dir /workspace/test/integration --verbose']
42+
# env:
43+
# - 'TF_VAR_org_id=$_ORG_ID'
44+
# - 'TF_VAR_parent_folder_id=$_FOLDER_ID'
45+
# - 'TF_VAR_billing_account=$_BILLING_ACCOUNT'
46+
# - 'TF_VAR_domain=test.blueprints.joonix.net'
47+
# - 'TF_VAR_serverless_folder_suffix=$SHORT_SHA'
48+
# - 'TF_VAR_create_access_context_manager_access_policy=false'
49+
# waitFor:
50+
# - prepare
5151
- id: create
5252
name: 'gcr.io/cloud-foundation-cicd/$_DOCKER_IMAGE_DEVELOPER_TOOLS:$_DOCKER_TAG_VERSION_DEVELOPER_TOOLS'
5353
args: ['/bin/bash', '-c', 'source /usr/local/bin/task_helper_functions.sh && kitchen_do create']
5454
waitFor:
55-
- create standalone
55+
- prepare
5656
- id: converge
5757
name: 'gcr.io/cloud-foundation-cicd/$_DOCKER_IMAGE_DEVELOPER_TOOLS:$_DOCKER_TAG_VERSION_DEVELOPER_TOOLS'
5858
args: ['/bin/bash', '-c', 'source /usr/local/bin/task_helper_functions.sh && kitchen_do converge']

modules/secure-cloud-run-security/metadata.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,13 +131,13 @@ spec:
131131
roles:
132132
- level: Project
133133
roles:
134+
- roles/artifactregistry.admin
134135
- roles/iam.serviceAccountUser
135136
- roles/serviceusage.serviceUsageViewer
136137
- roles/cloudkms.admin
137138
- roles/resourcemanager.projectIamAdmin
138139
- roles/run.admin
139140
- roles/iam.serviceAccountAdmin
140-
- roles/artifactregistry.admin
141141
services:
142142
- accesscontextmanager.googleapis.com
143143
- cloudbilling.googleapis.com

modules/secure-cloud-run/metadata.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,13 +248,13 @@ spec:
248248
roles:
249249
- level: Project
250250
roles:
251+
- roles/run.admin
251252
- roles/iam.serviceAccountAdmin
252253
- roles/artifactregistry.admin
253254
- roles/iam.serviceAccountUser
254255
- roles/serviceusage.serviceUsageViewer
255256
- roles/cloudkms.admin
256257
- roles/resourcemanager.projectIamAdmin
257-
- roles/run.admin
258258
services:
259259
- accesscontextmanager.googleapis.com
260260
- cloudbilling.googleapis.com

modules/secure-serverless-harness/metadata.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,13 +280,13 @@ spec:
280280
roles:
281281
- level: Project
282282
roles:
283-
- roles/run.admin
284283
- roles/iam.serviceAccountAdmin
285284
- roles/artifactregistry.admin
286285
- roles/iam.serviceAccountUser
287286
- roles/serviceusage.serviceUsageViewer
288287
- roles/cloudkms.admin
289288
- roles/resourcemanager.projectIamAdmin
289+
- roles/run.admin
290290
services:
291291
- accesscontextmanager.googleapis.com
292292
- cloudbilling.googleapis.com

modules/secure-serverless-net/metadata.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,13 +118,13 @@ spec:
118118
roles:
119119
- level: Project
120120
roles:
121+
- roles/serviceusage.serviceUsageViewer
122+
- roles/cloudkms.admin
121123
- roles/resourcemanager.projectIamAdmin
122124
- roles/run.admin
123125
- roles/iam.serviceAccountAdmin
124126
- roles/artifactregistry.admin
125127
- roles/iam.serviceAccountUser
126-
- roles/serviceusage.serviceUsageViewer
127-
- roles/cloudkms.admin
128128
services:
129129
- accesscontextmanager.googleapis.com
130130
- cloudbilling.googleapis.com

modules/v2/metadata.display.yaml

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,11 @@ spec:
6969
memory:
7070
name: memory
7171
title: Memory
72-
subtext: Memory to allocate to each instance of this container
72+
subtext: Memory to allocate to each instance of this container (e.g., 256Mi, 4Gi).
73+
nvidia_gpu:
74+
name: nvidia_gpu
75+
title: Nvidia GPU
76+
subtext: Number of GPUs to allocate to each instance of this container. Requires a minimum of 4 vCPUs and 16Gi of memory Maximum instance count for this template is 3. A node selector must be provided for GPU allocation.
7377
startup_probe:
7478
name: startup_probe
7579
title: Startup Probe
@@ -316,7 +320,6 @@ spec:
316320
- type: ALTERNATE_TYPE_DC
317321
value:
318322
min_instance_count: 0
319-
max_instance_count: 100
320323
timeout:
321324
name: timeout
322325
title: Timeout
@@ -399,6 +402,16 @@ spec:
399402
network_interfaces:
400403
network: default
401404
subnetwork: default
405+
node_selector:
406+
name: node_selector
407+
title: Node Selector
408+
level: 1
409+
gpu_zonal_redundancy_disabled:
410+
name: gpu_zonal_redundancy_disabled
411+
title: GPU Zonal Redundancy disabled
412+
altDefaults:
413+
- type: ALTERNATE_TYPE_DC
414+
value: false
402415
runtime:
403416
outputs:
404417
service_uri:

modules/v2/metadata.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -322,6 +322,10 @@ spec:
322322
description: Users/SAs to be given invoker access to the service. Grant invoker access by specifying the users or service accounts (SAs). Use allUsers for public access, allAuthenticatedUsers for access by logged-in Google users, or provide a list of specific users/SAs. [See the complete list of available options here](https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/cloud_run_v2_service_iam#member\/members-1)
323323
varType: list(string)
324324
defaultValue: []
325+
- name: iap_members
326+
description: Valid only when launch stage is set to 'BETA'. IAP is enabled automatically when users or service accounts (SAs) are provided. Use allUsers for public access, allAuthenticatedUsers for any Google-authenticated user, or specify individual users/SAs. [More info](https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/iap_web_cloud_run_service_iam#member\/members-2)
327+
varType: list(string)
328+
defaultValue: []
325329
- name: vpc_access
326330
description: Configure this to enable your service to send traffic to a Virtual Private Cloud. Set egress to ALL_TRAFFIC or PRIVATE_RANGES_ONLY. Choose a connector or network_interfaces (for direct VPC egress). [More info](https://cloud.google.com/run/docs/configuring/connecting-vpc)
327331
varType: |-
@@ -495,10 +499,6 @@ spec:
495499
description: The sandbox environment to host this Revision.
496500
varType: string
497501
defaultValue: EXECUTION_ENVIRONMENT_GEN2
498-
- name: iap_members
499-
description: Valid only when launch stage is set to 'BETA'. IAP is enabled automatically when users or service accounts (SAs) are provided. Use allUsers for public access, allAuthenticatedUsers for any Google-authenticated user, or specify individual users/SAs. [More info](https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/iap_web_cloud_run_service_iam#member\/members-2)
500-
varType: list(string)
501-
defaultValue: []
502502
outputs:
503503
- name: apphub_service_uri
504504
description: Service URI in CAIS style to be used by Apphub.
@@ -563,13 +563,13 @@ spec:
563563
roles:
564564
- level: Project
565565
roles:
566-
- roles/iam.serviceAccountUser
567-
- roles/serviceusage.serviceUsageViewer
568566
- roles/resourcemanager.projectIamAdmin
569567
- roles/compute.viewer
570568
- roles/iap.admin
571569
- roles/run.admin
572570
- roles/iam.serviceAccountAdmin
571+
- roles/iam.serviceAccountUser
572+
- roles/serviceusage.serviceUsageViewer
573573
services:
574574
- cloudresourcemanager.googleapis.com
575575
- compute.googleapis.com

modules/v2/variables.tf

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,12 @@ variable "members" {
156156
default = []
157157
}
158158

159+
variable "iap_members" {
160+
type = list(string)
161+
description = "Valid only when launch stage is set to 'BETA'. IAP is enabled automatically when users or service accounts (SAs) are provided. Use allUsers for public access, allAuthenticatedUsers for any Google-authenticated user, or specify individual users/SAs. [More info](https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/iap_web_cloud_run_service_iam#member\\/members-2)"
162+
default = []
163+
}
164+
159165
variable "vpc_access" {
160166
type = object({
161167
connector = optional(string)
@@ -351,8 +357,3 @@ variable "execution_environment" {
351357
}
352358
}
353359

354-
variable "iap_members" {
355-
type = list(string)
356-
description = "Valid only when launch stage is set to 'BETA'. IAP is enabled automatically when users or service accounts (SAs) are provided. Use allUsers for public access, allAuthenticatedUsers for any Google-authenticated user, or specify individual users/SAs. [More info](https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/iap_web_cloud_run_service_iam#member\\/members-2)"
357-
default = []
358-
}

0 commit comments

Comments
 (0)