Skip to content
This repository was archived by the owner on Dec 10, 2021. It is now read-only.

Is the Managed Instance Group in the examples needed? #89

@idsvandermolen

Description

@idsvandermolen

A lot of the examples (ha-nat-gateway and multiple-nat-environments for example) use the nat-gateway-module and in addition to this use add their own managed-instance-group. For example at https://github.com/GoogleCloudPlatform/terraform-google-nat-gateway/blob/master/examples/ha-nat-gateway/main.tf#L81 .

However, the nat-gateway-module already uses a managed instance group to manage the nat gateway instances (see https://github.com/GoogleCloudPlatform/terraform-google-nat-gateway/blob/master/main.tf#L47).

Unless I'm mistaken I think the managed instances groups in the examples are not used at all and could be removed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions