feat: native ignore-mutation support in applier #1883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all |
sdowell
force-pushed
the
native-ignore-mutation-in-applier
branch
from
401f124 to
d0620d0
Compare
|
/test all |
sdowell
force-pushed
the
native-ignore-mutation-in-applier
branch
from
d0620d0 to
e4f013c
Compare
|
/test all |
sdowell
force-pushed
the
native-ignore-mutation-in-applier
branch
from
e4f013c to
2315e88
Compare
|
/test all |
sdowell
force-pushed
the
native-ignore-mutation-in-applier
branch
2 times, most recently
from
2496c7c to
00faa72
Compare
|
/test all |
sdowell
force-pushed
the
native-ignore-mutation-in-applier
branch
from
00faa72 to
6751ae4
Compare
sdowell
force-pushed
the
native-ignore-mutation-in-applier
branch
from
6751ae4 to
5658e2f
Compare
This change reimplements the ignore-mutation feature using the native support in the cli-utils applier. This removes the need for the workaround of caching the object in Config Sync and passing in the cached object to the applier. This fixes several race conditions and side effects associated with the caching solution.
sdowell
force-pushed
the
native-ignore-mutation-in-applier
branch
from
5658e2f to
462ccba
Compare
sdowell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reimplements the ignore-mutation feature using the native
support in the cli-utils applier. This removes the need for the
workaround of caching the object in Config Sync and passing in the
cached object to the applier.
This fixes several race conditions and side effects associated with the
caching solution.
Fixes: #1668