Upgrade to golang 1.14

Close #328

Author: antechrestos

.travis.yml

@@ -1,9 +1,8 @@
 language: go
 os: linux
-go: 1.9.x
-
+go:
+  - "1.14"
 sudo: required
-
 services:
   - docker
 

Dockerfile.build

@@ -1,6 +1,4 @@
 # Dockerfile used to build a build step that builds container-diff in CI.
-FROM golang:1.9
+FROM golang:1.14
 RUN apt-get update && apt-get install make
-RUN mkdir -p /go/src/github.com/GoogleContainerTools/
-RUN ln -s /workspace /go/src/github.com/GoogleContainerTools/container-diff
-WORKDIR /go/src/github.com/GoogleContainerTools/container-diff
+WORKDIR     /workspace

pkg/util/transport_builder.go

@@ -19,13 +19,10 @@ package util
 import (
 	"crypto/tls"
 	"crypto/x509"
+	. "github.com/google/go-containerregistry/pkg/name"
 	"github.com/sirupsen/logrus"
 	"io/ioutil"
-	"net"
 	"net/http"
-	"time"
-
-	. "github.com/google/go-containerregistry/pkg/name"
 )
 
 var tlsConfiguration = struct {
@@ -48,7 +45,8 @@ func ConfigureTLS(skipTsVerifyRegistries []string, registriesToCertificates map[
 }
 
 func BuildTransport(registry Registry) http.RoundTripper {
-	var tr http.RoundTripper = newTransport()
+	var tr http.RoundTripper = http.DefaultTransport.(*http.Transport).Clone()
+
 	if _, present := tlsConfiguration.skipTLSVerifyRegistries[registry.RegistryStr()]; present {
 		tr.(*http.Transport).TLSClientConfig = &tls.Config{
 			InsecureSkipVerify: true,
@@ -66,22 +64,6 @@ func BuildTransport(registry Registry) http.RoundTripper {
 	return tr
 }
 
-// TODO replace it with "http.DefaultTransport.(*http.Transport).Clone()" once in golang 1.12
-func newTransport() http.RoundTripper {
-	return &http.Transport{
-		Proxy: http.ProxyFromEnvironment,
-		DialContext: (&net.Dialer{
-			Timeout:   30 * time.Second,
-			KeepAlive: 30 * time.Second,
-			DualStack: true,
-		}).DialContext,
-		MaxIdleConns:          100,
-		IdleConnTimeout:       90 * time.Second,
-		TLSHandshakeTimeout:   10 * time.Second,
-		ExpectContinueTimeout: 1 * time.Second,
-	}
-}
-
 func appendCertificate(pool *x509.CertPool, path string) error {
 	pem, err := ioutil.ReadFile(path)
 	if err != nil {