add tests

Author: nkubala

cmd/analyze_test.go

@@ -29,11 +29,11 @@ var analyzeArgNumTests = []testpair{
 func TestAnalyzeArgNum(t *testing.T) {
 	for _, test := range analyzeArgNumTests {
 		err := checkAnalyzeArgNum(test.input)
-		if (err == nil) != test.expected_output {
-			if test.expected_output {
-				t.Errorf("Got unexpected error: %s", err)
-			} else {
+		if (err == nil) != test.shouldError {
+			if test.shouldError {
 				t.Errorf("Expected error but got none")
+			} else {
+				t.Errorf("Got unexpected error: %s", err)
 			}
 		}
 	}

cmd/diff_test.go

@@ -21,21 +21,46 @@ import (
 )
 
 var diffArgNumTests = []testpair{
-	{[]string{}, false},
-	{[]string{"one"}, false},
-	{[]string{"one", "two"}, true},
-	{[]string{"one", "two", "three"}, false},
+	{[]string{}, true},
+	{[]string{"one"}, true},
+	{[]string{"one", "two"}, false},
+	{[]string{"one", "two", "three"}, true},
 }
 
 func TestDiffArgNum(t *testing.T) {
 	for _, test := range diffArgNumTests {
 		err := checkDiffArgNum(test.input)
-		if (err == nil) != test.expected_output {
-			if test.expected_output {
-				t.Errorf("Got unexpected error: %s", err)
-			} else {
-				t.Errorf("Expected error but got none")
-			}
+		checkError(t, err, test.shouldError)
+	}
+}
+
+type imageDiff struct {
+	image1      string
+	image2      string
+	shouldError bool
+}
+
+var imageDiffs = []imageDiff{
+	{"", "", true},
+	{"gcr.io/google-appengine/python", "gcr.io/google-appengine/debian9", false},
+	{"gcr.io/google-appengine/python", "cats", true},
+}
+
+func TestDiffImages(t *testing.T) {
+	for _, test := range imageDiffs {
+		err := diffImages(test.image1, test.image2, []string{"apt"})
+		checkError(t, err, test.shouldError)
+		err = diffImages(test.image1, test.image2, []string{"metadata"})
+		checkError(t, err, test.shouldError)
+	}
+}
+
+func checkError(t *testing.T, err error, shouldError bool) {
+	if (err == nil) == shouldError {
+		if shouldError {
+			t.Errorf("expected error but got none")
+		} else {
+			t.Errorf("got unexpected error: %s", err)
 		}
 	}
 }

cmd/root_test.go

@@ -17,6 +17,6 @@ limitations under the License.
 package cmd
 
 type testpair struct {
-	input           []string
-	expected_output bool
+	input       []string
+	shouldError bool
 }