Skip to content

Commit 47fb3be

Browse files
authored
Merge pull request #34 from iastewar/distroless-image
Changed the base image in the Dockerfile to be the same as ko
2 parents 6773085 + 5d195dc commit 47fb3be

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
FROM scratch
15+
# base image is the same as ko's default
16+
FROM cgr.dev/chainguard/static:latest
1617
COPY gcp-auth-webhook /gcp-auth-webhook
1718
ENTRYPOINT ["/gcp-auth-webhook"]

README.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,6 @@ Use the image `gcr.io/k8s-minikube/gcp-auth-webhook` as the image for a Deployme
1212

1313
## Running Locally
1414
The easiest way to run the server locally is:
15-
* Remove `FROM scratch` in the Dockerfile and replace it with the following to ensure https requests work properly locally:
16-
```
17-
FROM alpine
18-
RUN apk --no-cache add ca-certificates
19-
```
2015
* Modify [minikube's](https://github.com/kubernetes/minikube/blob/master/deploy/addons/gcp-auth/gcp-auth-webhook.yaml.tmpl) gcp-auth Deployment image to be `local/gcp-auth-webhook:$(VERSION)` (replace `$(VERSION)` with your version)
2116
* Build and run minikube
2217
* Run `eval $(path_to_minikube/minikube docker-env)` and then `make local-image` to make the image available from within minikube

0 commit comments

Comments
 (0)