Skip to content

Commit 7440adc

Browse files
committed
clean up error logging
1 parent 7a077b0 commit 7440adc

File tree

1 file changed

+8
-14
lines changed

1 file changed

+8
-14
lines changed

server.go

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ func needsEnvVar(c corev1.Container, name string) bool {
312312
return true
313313
}
314314

315-
func updateCheck() error {
315+
func updateCheck() {
316316
type release struct {
317317
Name string `json:"name"`
318318
}
@@ -321,41 +321,35 @@ func updateCheck() error {
321321

322322
resp, err := http.Get("https://storage.googleapis.com/minikube-gcp-auth/releases.json")
323323
if err != nil {
324-
return fmt.Errorf("failed to get releases file: %v", err)
324+
log.Printf("failed to get releases file: %v", err)
325325
}
326326
defer resp.Body.Close()
327327
if err := json.NewDecoder(resp.Body).Decode(&releases); err != nil {
328-
return fmt.Errorf("failed to decode releases file: %v", err)
328+
log.Printf("failed to decode releases file: %v", err)
329329
}
330330
if len(releases) == 0 {
331-
return fmt.Errorf("no releases found in releases file")
331+
log.Printf("no releases found in releases file")
332332
}
333333

334334
currVersion, err := semver.ParseTolerant(Version)
335335
if err != nil {
336-
return fmt.Errorf("unable to parse current version: %v", err)
336+
log.Printf("unable to parse current version: %v", err)
337337
}
338338
name := releases[0].Name
339339
latestVersion, err := semver.ParseTolerant(name)
340340
if err != nil {
341-
return fmt.Errorf("unable to parse latest version: %v", err)
341+
log.Printf("unable to parse latest version: %v", err)
342342
}
343343

344344
if currVersion.LT(latestVersion) {
345345
log.Printf("gcp-auth-webhook %s is available!", name)
346346
}
347-
348-
return nil
349347
}
350348

351349
func updateTicker() {
352-
if err := updateCheck(); err != nil {
353-
log.Println(err)
354-
}
350+
updateCheck()
355351
for range time.Tick(12 * time.Hour) {
356-
if err := updateCheck(); err != nil {
357-
log.Println(err)
358-
}
352+
updateCheck()
359353
}
360354
}
361355

0 commit comments

Comments
 (0)