Skip to content

Commit 5e071ee

Browse files
committed
update command in integration-in-docker and fix repo path
1 parent 6e84083 commit 5e071ee

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

Makefile

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,14 @@ GKE_REGION=us-central1
3939
ifeq ($(GCP_PROJECT),skaffold-ci-cd)
4040
# Presubmit environment: skaffold-ci-cd project with Artifact Registry
4141
IMAGE_REPO_BASE := $(AR_REGION)-docker.pkg.dev/$(GCP_PROJECT)
42+
BUILD_DEPS_REPO_NAME := builddeps
4243
GCLOUD_AUTH_CONFIG := $(AR_REGION)-docker.pkg.dev
4344
GKE_LOCATION_FLAG := --region $(GKE_REGION)
4445
$(info Using Artifact Registry config for project: $(GCP_PROJECT))
4546
else
4647
# k8s-skaffold project with GCR
4748
IMAGE_REPO_BASE := gcr.io/$(GCP_PROJECT)
49+
BUILD_DEPS_REPO_NAME := build_deps
4850
GCLOUD_AUTH_CONFIG := gcr.io
4951
GKE_LOCATION_FLAG := --zone $(GKE_ZONE)
5052
$(info Using GCR config for project: $(GCP_PROJECT))
@@ -224,23 +226,23 @@ build_deps:
224226
$(eval DEPS_DIGEST := $(shell ./hack/skaffold-deps-sha1.sh))
225227
docker build \
226228
-f deploy/skaffold/Dockerfile.deps \
227-
-t $(IMAGE_REPO_BASE)/build_deps:$(DEPS_DIGEST) \
229+
-t $(IMAGE_REPO_BASE)/$(BUILD_DEPS_REPO_NAME):$(DEPS_DIGEST) \
228230
deploy/skaffold
229231
docker push $(IMAGE_REPO_BASE)/build_deps:$(DEPS_DIGEST)
230232

231233

232234
skaffold-builder-ci:
233235
docker buildx build \
234236
--load \
235-
--cache-from $(IMAGE_REPO_BASE)/build_deps:$(DEPS_DIGEST) \
237+
--cache-from $(IMAGE_REPO_BASE)/$(BUILD_DEPS_REPO_NAME):$(DEPS_DIGEST) \
236238
-f deploy/skaffold/Dockerfile.deps \
237239
-t $(IMAGE_REPO_BASE)/build_deps \
238240
.
239241
time docker buildx build \
240242
--load \
241243
-f deploy/skaffold/Dockerfile \
242244
--target builder \
243-
--cache-from $(IMAGE_REPO_BASE)/build_deps \
245+
--cache-from $(IMAGE_REPO_BASE)/$(BUILD_DEPS_REPO_NAME):$(DEPS_DIGEST) \
244246
-t $(IMAGE_REPO_BASE)/skaffold-builder \
245247
.
246248

@@ -326,7 +328,7 @@ integration-in-docker: skaffold-builder-ci
326328
-e GRADLE_USER_HOME \
327329
-e BUILDX_BUILDER=skaffold-builder \
328330
$(IMAGE_REPO_BASE)/skaffold-builder \
329-
sh -c "gcloud auth configure-docker us-central1-docker.pkg.dev -q && make integration-tests"
331+
sh -c "gcloud auth configure-docker us-central1-docker.pkg.dev -q && docker buildx create --use --name skaffold-builder --driver docker-container && BUILDX_BUILDER=skaffold-builder make integration-tests"
330332

331333
.PHONY: submit-build-trigger
332334
submit-build-trigger:

0 commit comments

Comments
 (0)