Skip to content

Commit 6ccf0cb

Browse files
committed
fix(kustomize): Updated generator support for both EnvSources and FileSources using [{key}=]{path} syntax
1 parent 5c43036 commit 6ccf0cb

File tree

1 file changed

+58
-8
lines changed

1 file changed

+58
-8
lines changed

pkg/skaffold/render/renderer/kustomize/kustomize.go

Lines changed: 58 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -401,6 +401,18 @@ func (k Kustomize) mirrorSecretGenerators(kusDir string, fs TmpFS, args []types.
401401
for _, arg := range args {
402402
if arg.FileSources != nil {
403403
for _, f := range arg.FileSources {
404+
// Entries from FileSources can take the form: [{key}=]{path}
405+
i := strings.IndexRune(f, '=')
406+
if i > -1 {
407+
f = f[i+1:]
408+
}
409+
if err := k.mirrorFile(kusDir, fs, f); err != nil {
410+
return err
411+
}
412+
}
413+
}
414+
if arg.EnvSources != nil {
415+
for _, f := range arg.EnvSources {
404416
if err := k.mirrorFile(kusDir, fs, f); err != nil {
405417
return err
406418
}
@@ -414,6 +426,18 @@ func (k Kustomize) mirrorConfigMapGenerators(kusDir string, fs TmpFS, args []typ
414426
for _, arg := range args {
415427
if arg.FileSources != nil {
416428
for _, f := range arg.FileSources {
429+
// Entries from FileSources can take the form: [{key}=]{path}
430+
i := strings.IndexRune(f, '=')
431+
if i > -1 {
432+
f = f[i+1:]
433+
}
434+
if err := k.mirrorFile(kusDir, fs, f); err != nil {
435+
return err
436+
}
437+
}
438+
}
439+
if arg.EnvSources != nil {
440+
for _, f := range arg.EnvSources {
417441
if err := k.mirrorFile(kusDir, fs, f); err != nil {
418442
return err
419443
}
@@ -524,21 +548,47 @@ func DependenciesForKustomization(dir string) ([]string, error) {
524548
}
525549

526550
for _, generator := range content.ConfigMapGenerator {
527-
deps = append(deps, sUtil.AbsolutePaths(dir, generator.FileSources)...)
528-
envs := generator.EnvSources
551+
var sources []string
552+
553+
if generator.FileSources != nil {
554+
for _, f := range generator.FileSources {
555+
// Entries from FileSources can take the form: [{key}=]{path}
556+
i := strings.IndexRune(f, '=')
557+
if i > -1 {
558+
f = f[i+1:]
559+
}
560+
sources = append(sources, f)
561+
}
562+
}
563+
564+
sources = append(sources, generator.EnvSources...)
529565
if generator.EnvSource != "" {
530-
envs = append(envs, generator.EnvSource)
566+
sources = append(sources, generator.EnvSource)
531567
}
532-
deps = append(deps, sUtil.AbsolutePaths(dir, envs)...)
568+
569+
deps = append(deps, sUtil.AbsolutePaths(dir, sources)...)
533570
}
534571

535572
for _, generator := range content.SecretGenerator {
536-
deps = append(deps, sUtil.AbsolutePaths(dir, generator.FileSources)...)
537-
envs := generator.EnvSources
573+
var sources []string
574+
575+
if generator.FileSources != nil {
576+
for _, f := range generator.FileSources {
577+
// Entries from FileSources can take the form: [{key}=]{path}
578+
i := strings.IndexRune(f, '=')
579+
if i > -1 {
580+
f = f[i+1:]
581+
}
582+
sources = append(sources, f)
583+
}
584+
}
585+
586+
sources = append(sources, generator.EnvSources...)
538587
if generator.EnvSource != "" {
539-
envs = append(envs, generator.EnvSource)
588+
sources = append(sources, generator.EnvSource)
540589
}
541-
deps = append(deps, sUtil.AbsolutePaths(dir, envs)...)
590+
591+
deps = append(deps, sUtil.AbsolutePaths(dir, sources)...)
542592
}
543593

544594
return deps, nil

0 commit comments

Comments
 (0)