Skip to content

Commit e9826a0

Browse files
committed
Improve sync error handling in dev.go
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
1 parent 628c383 commit e9826a0

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

pkg/skaffold/runner/dev.go

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,13 @@ func (r *SkaffoldRunner) doDev(ctx context.Context, out io.Writer) error {
100100
err := backoff.Retry(
101101
func() error {
102102
err := syncHandler(s)
103-
if err == nil || os.IsNotExist(err) {
103+
if err == nil {
104+
return nil
105+
}
106+
107+
// If file doesn't exist (e.g., deleted), stop retrying
108+
if os.IsNotExist(err) {
109+
log.Entry(ctx).Infof("Skipping sync for %s: file no longer exists", s.Image)
104110
return nil
105111
}
106112

@@ -109,7 +115,8 @@ func (r *SkaffoldRunner) doDev(ctx context.Context, out io.Writer) error {
109115
)
110116

111117
if err != nil {
112-
return nil
118+
log.Entry(ctx).Warnf("Sync failed after retries for %s: %v", s.Image, err)
119+
continue
113120
}
114121
}
115122
endTrace()

0 commit comments

Comments
 (0)