diff --git a/package-lock.json b/package-lock.json index be7c014ae18b..621ba2bd6344 100644 --- a/package-lock.json +++ b/package-lock.json @@ -98,7 +98,7 @@ "eslint-plugin-react-hooks": "^6.0.0-rc.1", "eslint-plugin-security": "^3.0.1", "eslint-plugin-styled-components-a11y": "^2.2.1", - "eslint-plugin-testing-library": "^7.6.3", + "eslint-plugin-testing-library": "^7.6.6", "html-webpack-plugin": "^5.6.4", "husky": "^9.1.7", "jest": "^29.7.0", @@ -17248,9 +17248,9 @@ } }, "node_modules/eslint-plugin-testing-library": { - "version": "7.6.3", - "resolved": "https://registry.npmjs.org/eslint-plugin-testing-library/-/eslint-plugin-testing-library-7.6.3.tgz", - "integrity": "sha512-tI/epV/DD4+nJ51VGg7MWfqajMAW0+U+9dTLFrnqrJHoPO2TyGRU8ASrPNFPe2zzDT1qwznkCeeqMzViALgiig==", + "version": "7.6.6", + "resolved": "https://registry.npmjs.org/eslint-plugin-testing-library/-/eslint-plugin-testing-library-7.6.6.tgz", + "integrity": "sha512-eSexC+OPhDLuCpLbFEC7Qrk0x4IE4Mn+UW0db8YAhUatVB6CzGHdeHv4pyoInglbhhQc0Z9auY/2HKyMZW5s7Q==", "dev": true, "license": "MIT", "dependencies": { diff --git a/package.json b/package.json index 4608376cc087..5319cc6c6ab0 100644 --- a/package.json +++ b/package.json @@ -122,7 +122,7 @@ "eslint-plugin-react-hooks": "^6.0.0-rc.1", "eslint-plugin-security": "^3.0.1", "eslint-plugin-styled-components-a11y": "^2.2.1", - "eslint-plugin-testing-library": "^7.6.3", + "eslint-plugin-testing-library": "^7.6.6", "html-webpack-plugin": "^5.6.4", "husky": "^9.1.7", "jest": "^29.7.0", diff --git a/packages/story-editor/src/components/library/panes/pageTemplates/templateSave.js b/packages/story-editor/src/components/library/panes/pageTemplates/templateSave.js index 73daa00133ef..1e4e7c93a4af 100644 --- a/packages/story-editor/src/components/library/panes/pageTemplates/templateSave.js +++ b/packages/story-editor/src/components/library/panes/pageTemplates/templateSave.js @@ -122,7 +122,6 @@ function TemplateSave({ setShowDefaultTemplates, updateList }) { return; } - let imageId; let tmpPageDataUrl; const currentPageCanvas = pageCanvasMap[currentPage.id]; if (currentPageCanvas) { @@ -139,7 +138,7 @@ function TemplateSave({ setShowDefaultTemplates, updateList }) { id: uuidv4(), version: DATA_VERSION, }, - featured_media: imageId, + featured_media: undefined, title: templateName !== '' ? templateName : __('Untitled', 'web-stories'), }); diff --git a/packages/story-editor/src/components/panels/design/sizePosition/test/sizePosition.js b/packages/story-editor/src/components/panels/design/sizePosition/test/sizePosition.js index 9472ee45bb60..c190efde0055 100644 --- a/packages/story-editor/src/components/panels/design/sizePosition/test/sizePosition.js +++ b/packages/story-editor/src/components/panels/design/sizePosition/test/sizePosition.js @@ -363,6 +363,7 @@ describe('panels/SizePosition', () => { }); expect(submitArg).toBeTrue(); + // eslint-disable-next-line testing-library/no-node-access -- False positive. const submits = submit({ width: 150, height: MULTIPLE_VALUE }); expect(submits[image.id]).toStrictEqual( expect.objectContaining({ @@ -393,6 +394,7 @@ describe('panels/SizePosition', () => { }); expect(submitArg).toBeTrue(); + // eslint-disable-next-line testing-library/no-node-access -- False positive. const submits = submit({ width: 150, height: MULTIPLE_VALUE }); expect(submits[image.id]).toStrictEqual( expect.objectContaining({ @@ -423,6 +425,7 @@ describe('panels/SizePosition', () => { }); expect(submitArg).toBeTrue(); + // eslint-disable-next-line testing-library/no-node-access -- False positive. const submits = submit({ height: 160, width: MULTIPLE_VALUE }); expect(submits[image.id]).toStrictEqual( expect.objectContaining({ @@ -481,6 +484,7 @@ describe('panels/SizePosition', () => { }); expect(submitArg).toBeTrue(); + // eslint-disable-next-line testing-library/no-node-access -- False positive. const submits = submit({ height: 2000, width: 2000 * (100 / 80) }); expect(submits[image.id]).toStrictEqual( expect.objectContaining({ diff --git a/packages/story-editor/src/components/panels/design/textStyle/test/textStyle.js b/packages/story-editor/src/components/panels/design/textStyle/test/textStyle.js index 4da5fadad3c2..81fdd76483d3 100644 --- a/packages/story-editor/src/components/panels/design/textStyle/test/textStyle.js +++ b/packages/story-editor/src/components/panels/design/textStyle/test/textStyle.js @@ -226,6 +226,7 @@ describe('Panels/TextStyle', () => { calculateTextHeight.mockImplementation(() => 171); const [dx, dy] = calcRotatedResizeOffset(0, 0, 0, 0, 171 - 100); + // eslint-disable-next-line testing-library/no-node-access -- False positive. const submits = submit({ fontSize: 70 }); expect(submits[textElement.id]).toStrictEqual({ fontSize: 70,