Enable warnings as errors and fix all warnings (#280)

https://developer.android.com/reference/tools/gradle-api/4.1/com/android/build/api/dsl/LintOptions#iswarningsaserrors
https://youtrack.jetbrains.com/issue/KT-10563/Support-a-command-line-argument-Werror-to-treat-warnings-as-errors

Author: Goooler

app/build.gradle.kts

@@ -21,7 +21,10 @@ android {
     dataBinding = true
     resValues = true
   }
-  lint.abortOnError = true
+  lint {
+    abortOnError = true
+    warningsAsErrors = true
+  }
   val releaseSigning = signingConfigs.create("release") {
     keyAlias = getSignProperty("keyAlias")
     keyPassword = getSignProperty("keyPassword")

base/src/main/kotlin/io/goooler/demoapp/base/core/BaseFragment.kt

@@ -10,6 +10,7 @@ abstract class BaseFragment : Fragment(), IFragment {
     super.onCreate(savedInstanceState)
     activity?.onBackPressedDispatcher?.addCallback(this) {
       isEnabled = onBackPressed()
+      @Suppress("DEPRECATION")
       if (!isEnabled) activity?.onBackPressed()
       isEnabled = true
     }

base/src/main/kotlin/io/goooler/demoapp/base/core/BaseService.kt

@@ -2,6 +2,8 @@ package io.goooler.demoapp.base.core
 
 import android.app.Notification
 import android.app.NotificationManager
+import android.app.Service
+import android.os.Build
 import androidx.annotation.DrawableRes
 import androidx.annotation.IntRange
 import androidx.core.app.NotificationChannelCompat
@@ -48,7 +50,12 @@ abstract class BaseService : LifecycleService() {
   }
 
   override fun onDestroy() {
-    stopForeground(true)
+    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
+      stopForeground(Service.STOP_FOREGROUND_REMOVE)
+    } else {
+      @Suppress("DEPRECATION")
+      stopForeground(true)
+    }
     super.onDestroy()
   }
 }

base/src/main/kotlin/io/goooler/demoapp/base/util/BaseExtensions.kt

@@ -83,14 +83,19 @@ inline val isMainThread: Boolean get() = Looper.getMainLooper() == Looper.myLoop
 fun <T : Any> unsafeLazy(initializer: () -> T): Lazy<T> =
   lazy(LazyThreadSafetyMode.NONE, initializer)
 
-fun <T : Parcelable> T.deepCopy(): T? {
+inline fun <reified T : Parcelable> T.deepCopy(): T? {
   var parcel: Parcel? = null
   return try {
     parcel = Parcel.obtain().also {
       it.writeParcelable(this, 0)
       it.setDataPosition(0)
     }
-    parcel.readParcelable(this::class.java.classLoader)
+    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
+      parcel.readParcelable(this::class.java.classLoader, T::class.java)
+    } else {
+      @Suppress("DEPRECATION")
+      parcel.readParcelable(this::class.java.classLoader)
+    }
   } finally {
     parcel?.recycle()
   }
@@ -362,13 +367,26 @@ fun Intent.getStringExtra(name: String, defaultValue: String): String =
 fun Intent.getCharSequenceExtra(name: String, defaultValue: CharSequence): CharSequence =
   getCharSequenceExtra(name) ?: defaultValue
 
-inline fun <reified T : Parcelable> Intent.getParcelableExtra(name: String, defaultValue: T): T =
-  getParcelableExtra(name) ?: defaultValue
+inline fun <reified T : Parcelable> Intent.getParcelableExtra(name: String, defaultValue: T): T {
+  return if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
+    getParcelableExtra(name, T::class.java)
+  } else {
+    @Suppress("DEPRECATION")
+    getParcelableExtra(name)
+  } ?: defaultValue
+}
 
 inline fun <reified T : Serializable> Intent.getSerializableExtra(
   name: String,
   defaultValue: T,
-): T = (getSerializableExtra(name) ?: defaultValue) as T
+): T {
+  return if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
+    getSerializableExtra(name, T::class.java)
+  } else {
+    @Suppress("DEPRECATION")
+    getSerializableExtra(name) as T
+  } ?: defaultValue
+}
 
 // ---------------------Fragment-------------------------------//
 
@@ -526,6 +544,7 @@ fun Context.setMusicMute(mute: Boolean = true) {
       val direction = if (mute) AudioManager.ADJUST_UNMUTE else AudioManager.ADJUST_MUTE
       it.adjustStreamVolume(AudioManager.STREAM_MUSIC, direction, 0)
     } else {
+      @Suppress("DEPRECATION")
       it.setStreamMute(AudioManager.STREAM_MUSIC, mute)
     }
   }

biz/login/src/main/kotlin/io/goooler/demoapp/login/ui/SplashActivity.kt

@@ -18,6 +18,7 @@ class SplashActivity : BaseActivity() {
     if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
       finish()
     } else {
+      @Suppress("DEPRECATION")
       super.onBackPressed()
     }
   }

biz/main/src/main/kotlin/io/goooler/demoapp/main/vm/MainSrlViewModel.kt

@@ -71,7 +71,7 @@ class MainSrlViewModel : BaseViewModel() {
         finishRefreshAndLoadMore(false)
         repository.getRepoListFromApi("goooler", page)
           .map { bean ->
-            MainCommonVhModel.Repo(bean.owner?.avatarUrl, bean.name, bean.fullName)
+            MainCommonVhModel.Repo(bean.owner.avatarUrl, bean.name, bean.fullName)
           }.let {
             _listData += it
             if (page == 1 && it.isEmpty()) {

build.gradle.kts

@@ -35,6 +35,7 @@ allprojects {
 
   tasks.withType<KotlinCompile> {
     kotlinOptions {
+      allWarningsAsErrors = true
       jvmTarget = JavaVersion.VERSION_11.toString()
     }
   }