Flavor feature seems broken

[Lotram]

I've noticed there is no test about flavors, so I wanted to add a simple one:

    def test_flavors(self):
        self.config["general"]["interactive"] = False
        self.config["flavor"] = {
            "work": {"targets": ["my_service", "my_gitlab"], "interactive": False},
            "personal": {"targets": ["my_kan"], "interactive": False},
        }

        conf = self.validate()

This breaks in validate_config. I checked, and this was already the case before I migrated the code to pydantic v2.
Maybe I'm wrong with my test, and the flavors are not passed like that ? I think it's the case, but I'm not sure.

We should add some tests about flavors anyway

[Lotram]

Note that it looks like the fix is simply to remove the .values() here:

flavor=(
            dict[str, MainSectionConfig],
            {
                flavor: (MainSectionConfig, ...)
                for flavor in config.get('flavor', {}).values()
            },
        )

[Lotram]

Testing this feature with the packaged 2.0.0 version, I can confirm it does not work

[Lotram]

The problem is actually deeper than I first thought. It might be a good time to refactor this a bit ?
In the code, there is no reason to treat general and other flavors differently, IMO the Config pydantic model does not need to know about flavors, as we know from the start which flavor to use. It can become main configuration right there.

[ryneeverett]

I'm also noticing that ini2toml quotes flavor sections which I don't believe will work because we rely on them being parsed into a nested 'flavor' dict.

>>> import tomllib
>>> tomllib.loads('[flavor.myflavor]')
{'flavor': {'myflavor': {}}}
>>> tomllib.loads('["flavor.myflavor"]')
{'flavor.myflavor': {}}