Allow to specify the listen address on the cli

Author: mroethke

README.md

@@ -71,7 +71,10 @@ The server is configured with command-line options. See
 `taskchampion-sync-server --help` for full details.
 
 The `--data-dir` option specifies where the server should store its data, and
-`--port` gives the port on which the HTTP server runs.
+`--port` gives the port on which the HTTP server runs. You can also specify the
+listen address with `--listen`. The default listen address ist localhost, so if
+you do not use a reverse proxy or have custom container based deployment you
+probably have to change this.
 
 By default, the server allows all client IDs. To limit the accepted client IDs,
 such as when running a personal server, use `--allow-client-id <client-id>`.

docker-compose.yml

@@ -56,7 +56,7 @@ services:
         volume:
           nocopy: true
           subpath: tss
-    command: --data-dir /tss/taskchampion-sync-server --port 8080
+    command: --data-dir /tss/taskchampion-sync-server --port 8080 --listen 0.0.0.0
     environment:
       - RUST_LOG=info
     depends_on:

server/src/bin/taskchampion-sync-server.rs

@@ -26,6 +26,13 @@ fn command() -> Command {
                 .value_parser(value_parser!(u16))
                 .default_value("8080"),
         )
+        .arg(
+            arg!(-l --listen <ADDRESS>)
+                .help("Address on which to listen on. Can be an IP Address or a DNS name. Can be repeated.")
+                .value_parser(ValueParser::string())
+                .default_value("localhost")
+                .action(ArgAction::Append),
+        )
         .arg(
             arg!(-d --"data-dir" <DIR> "Directory in which to store data")
                 .value_parser(ValueParser::os_string())
@@ -76,15 +83,16 @@ async fn main() -> anyhow::Result<()> {
     let server = WebServer::new(config, client_id_allowlist, SqliteStorage::new(data_dir)?);
 
     log::info!("Serving on port {}", port);
-    HttpServer::new(move || {
+    let mut http_server = HttpServer::new(move || {
         App::new()
             .wrap(ErrorHandlers::new().handler(StatusCode::INTERNAL_SERVER_ERROR, print_error))
             .wrap(Logger::default())
             .configure(|cfg| server.config(cfg))
-    })
-    .bind(("0.0.0.0", port))?
-    .run()
-    .await?;
+    });
+    for listen_address in matches.get_many::<String>("listen").unwrap() {
+        http_server = http_server.bind((listen_address.as_str(), port))?
+    }
+    http_server.run().await?;
     Ok(())
 }