Do not allow adding open intervals with a future time

If an interval is started at a future time, as was possible with the
continue command when given a future time, subsequent commands could
fail if the end data was set to the current time.

Which would result in the following message:
  Range.cpp:359: time_t Range::total() const: Assertion `is_open () || end >= start' failed.

This change makes it invalid to start an open interval in the future,
regardless of what command is validating the in the interval.  However
it might still be possible to get in this case if the time on the system
jumps backward after starting an interval.

Reported by @kbcb
Related to #350
Closes #364

Signed-off-by: Shaun Ruffell <sruffell@sruffell.net>

Author: sruffell

src/commands/CmdStart.cpp

@@ -40,11 +40,7 @@ int CmdStart (
 
   auto interval = cli.getFilter ({now, 0});
 
-  if (interval.start > now)
-  {
-    throw std::string ("Time tracking cannot be set in the future.");
-  }
-  else if (!interval.is_started () || interval.is_ended ())
+  if (!interval.is_started () || interval.is_ended ())
   {
     throw std::string ("The start command does not accept ranges but only a single datetime. "
                        "Perhaps you want the track command?.");

src/validate.cpp

@@ -211,7 +211,12 @@ bool validate (
     autoFill (rules, database, interval);
   }
 
-  return autoAdjust (findHint (cli, ":adjust"), rules, database, interval);
+  bool should_add = autoAdjust (findHint (cli, ":adjust"), rules, database, interval);
+  if (should_add && (interval.is_open () && interval.start > Datetime ()))
+  {
+    throw std::string ("Time tracking cannot be set in the future.");
+  }
+  return should_add;
 }
 
 ////////////////////////////////////////////////////////////////////////////////

test/continue.t

@@ -502,6 +502,23 @@ class TestContinue(TestCase):
                                   expectedTags=["FOO"],
                                   description="added interval")
 
+    def test_continue_with_future_time(self):
+        """Verify that continue fails with time in the future"""
+        now_utc = datetime.now().utcnow()
+
+        one_hour_before_utc = now_utc - timedelta(hours=1)
+        two_hours_before_utc = now_utc - timedelta(hours=2)
+
+        code, out, err = self.t("start FOO {:%Y-%m-%dT%H}:00:00Z".format(two_hours_before_utc))
+        self.assertIn("Tracking FOO\n", out)
+        code, out, err = self.t("start BAR {:%Y-%m-%dT%H}:00:00Z".format(one_hour_before_utc))
+        self.assertIn("Tracking BAR\n", out)
+        code, out, err = self.t("stop")
+        self.assertIn("Recorded BAR\n", out)
+
+        code, out, err = self.t.runError("continue @2 from {:%Y-%m-%dT%H:%M:%S}".format (now_utc + timedelta(seconds=10)))
+        self.assertIn("Time tracking cannot be set in the future", err)
+
 
 if __name__ == "__main__":
     from simpletap import TAPTestRunner