Skip to content

Commit 3c2ee89

Browse files
authored
Merge pull request #103 from GovTechSG/8.4.7
8.4.7
2 parents 3f767d6 + 4290361 commit 3c2ee89

File tree

7 files changed

+62
-223
lines changed

7 files changed

+62
-223
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
# Changelogs
22

3-
## x.x.x
3+
## 8.4.7
44

55
- Update convenience test suite to include SingPass login with PKCE
6+
- Update axios to v1.8.3
67

78
## 8.4.6
89

package-lock.json

Lines changed: 36 additions & 199 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@govtechsg/singpass-myinfo-oidc-helper",
3-
"version": "8.4.6",
3+
"version": "8.4.7",
44
"description": "Helper for building a Relying Party to integrate with Singpass OIDC and MyInfo person basic API",
55
"main": "dist/index.js",
66
"types": "dist/index.d.ts",

src/corppass/corppass-helper-ndi.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@ import { AxiosInstance, AxiosProxyConfig } from "axios";
22
import * as querystringUtil from "querystring";
33
import { createClient } from "../client/axios-client";
44
import { JweUtil } from "../util";
5+
import { DateUtils } from "../util/DateUtils";
56
import { SingpassMyInfoError } from "../util/error/SingpassMyinfoError";
6-
import { logger } from "../util/Logger";
7-
import { AuthInfo, EntityInfo, EserviceAuthResultRow, TokenResponse, TPAccessInfo, UserInfo } from "./shared-constants";
87
import { Key } from "../util/KeyUtil";
8+
import { logger } from "../util/Logger";
99
import { createClientAssertion } from "../util/SigningUtil";
10-
import { DateUtils } from "../util/DateUtils";
10+
import { AuthInfo, EntityInfo, EserviceAuthResultRow, TokenResponse, TPAccessInfo, UserInfo } from "./shared-constants";
1111

1212
interface AccessTokenPayload {
1313
exp: number;
@@ -179,7 +179,7 @@ export class NdiOidcHelper {
179179
if (error) {
180180
throw error;
181181
} else {
182-
throw new SingpassMyInfoError('could not verify with any key');
182+
throw new SingpassMyInfoError("could not verify with any key");
183183
}
184184
} catch (e) {
185185
logger.error("Failed to get access token payload", e);
@@ -219,7 +219,7 @@ export class NdiOidcHelper {
219219
if (error) {
220220
throw error;
221221
} else {
222-
throw new SingpassMyInfoError('could not verify with any key');
222+
throw new SingpassMyInfoError("could not verify with any key");
223223
}
224224
} catch (e) {
225225
logger.error("Failed to get ID token payload", e);

0 commit comments

Comments
 (0)