Merge branch 'main' into feat/storybook-ci-tests

Author: GabrielBianconi

.github/workflows/general.yml

@@ -734,7 +734,8 @@ jobs:
     # the main 'validate' job)
     runs-on: ${{ matrix.replicated && 'namespace-profile-tensorzero-8x16;ephemeral-storage.size-multiplier=2' || 'namespace-profile-tensorzero-8x16' }}
     continue-on-error: ${{ matrix.clickhouse_version.allow_failure }}
-    if: github.repository == 'tensorzero/tensorzero'
+    # This needs to pull from Docker Hub, so skip for external PR CI
+    if: ${{ (github.event.pull_request.head.repo.full_name == github.repository) || inputs.is_merge_group }}
     strategy:
       matrix:
         # Only include replicated: true when running in merge queue

tensorzero-core/tests/e2e/providers/common.rs

@@ -3621,7 +3621,6 @@ pub async fn check_simple_image_inference_response(
 }
 
 pub async fn test_streaming_invalid_request_with_provider(provider: E2ETestProvider) {
-    // A top_p of -100 and temperature of -100 should produce errors on all providers
     let extra_headers = if provider.is_modal_provider() {
         get_modal_extra_headers()
     } else {
@@ -3630,10 +3629,13 @@ pub async fn test_streaming_invalid_request_with_provider(provider: E2ETestProvi
     let payload = json!({
         "function_name": "basic_test",
         "variant_name": provider.variant_name,
+        // Set lots of invalid parameters to try to produce an error on all providers
         "params": {
             "chat_completion": {
                 "temperature": -100,
                 "top_p": -100,
+                "presence_penalty": -100,
+                "frequency_penalty": -100,
             }
         },
         "input":
@@ -3673,10 +3675,13 @@ pub async fn test_streaming_invalid_request_with_provider(provider: E2ETestProvi
         assert_eq!(code, StatusCode::INTERNAL_SERVER_ERROR);
         let resp: Value = resp.json().await.unwrap();
         let err_msg = resp.get("error").unwrap().as_str().unwrap();
+        println!("Error message: {err_msg}");
         assert!(
             err_msg.contains("top_p")
                 || err_msg.contains("topP")
-                || err_msg.contains("temperature"),
+                || err_msg.contains("temperature")
+                || err_msg.contains("presence_penalty")
+                || err_msg.contains("frequency_penalty"),
             "Unexpected error message: {resp}"
         );
     }