Skip to content

Commit 1bedb4c

Browse files
authored
Remove Named from the parents of Transformer (#1289)
It's unused.
1 parent 16d7e49 commit 1bedb4c

File tree

3 files changed

+6
-11
lines changed

3 files changed

+6
-11
lines changed

api/shadow.api

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,6 @@ public abstract interface class com/github/jengelman/gradle/plugins/shadow/tasks
265265
public class com/github/jengelman/gradle/plugins/shadow/transformers/ApacheLicenseResourceTransformer : com/github/jengelman/gradle/plugins/shadow/transformers/Transformer {
266266
public fun <init> ()V
267267
public fun canTransformResource (Lorg/gradle/api/file/FileTreeElement;)Z
268-
public fun getName ()Ljava/lang/String;
269268
public fun getObjectFactory ()Lorg/gradle/api/model/ObjectFactory;
270269
public fun hasTransformedResource ()Z
271270
public fun modifyOutputStream (Lorg/apache/tools/zip/ZipOutputStream;Z)V
@@ -326,7 +325,6 @@ public final class com/github/jengelman/gradle/plugins/shadow/transformers/Compo
326325
public class com/github/jengelman/gradle/plugins/shadow/transformers/DontIncludeResourceTransformer : com/github/jengelman/gradle/plugins/shadow/transformers/Transformer {
327326
public fun <init> (Lorg/gradle/api/model/ObjectFactory;)V
328327
public fun canTransformResource (Lorg/gradle/api/file/FileTreeElement;)Z
329-
public fun getName ()Ljava/lang/String;
330328
public final fun getObjectFactory ()Lorg/gradle/api/model/ObjectFactory;
331329
public fun getResource ()Lorg/gradle/api/provider/Property;
332330
public fun hasTransformedResource ()Z
@@ -358,7 +356,6 @@ public class com/github/jengelman/gradle/plugins/shadow/transformers/IncludeReso
358356
public fun <init> (Lorg/gradle/api/model/ObjectFactory;)V
359357
public fun canTransformResource (Lorg/gradle/api/file/FileTreeElement;)Z
360358
public fun getFile ()Lorg/gradle/api/file/RegularFileProperty;
361-
public fun getName ()Ljava/lang/String;
362359
public final fun getObjectFactory ()Lorg/gradle/api/model/ObjectFactory;
363360
public fun getResource ()Lorg/gradle/api/provider/Property;
364361
public fun hasTransformedResource ()Z
@@ -460,11 +457,10 @@ public class com/github/jengelman/gradle/plugins/shadow/transformers/ServiceFile
460457
public fun transform (Lcom/github/jengelman/gradle/plugins/shadow/transformers/TransformerContext;)V
461458
}
462459

463-
public abstract interface class com/github/jengelman/gradle/plugins/shadow/transformers/Transformer : org/gradle/api/Named {
460+
public abstract interface class com/github/jengelman/gradle/plugins/shadow/transformers/Transformer {
464461
public static final field Companion Lcom/github/jengelman/gradle/plugins/shadow/transformers/Transformer$Companion;
465462
public abstract fun canTransformResource (Lorg/gradle/api/file/FileTreeElement;)Z
466463
public static fun create (Ljava/lang/Class;Lorg/gradle/api/model/ObjectFactory;)Lcom/github/jengelman/gradle/plugins/shadow/transformers/Transformer;
467-
public fun getName ()Ljava/lang/String;
468464
public fun getObjectFactory ()Lorg/gradle/api/model/ObjectFactory;
469465
public abstract fun hasTransformedResource ()Z
470466
public abstract fun modifyOutputStream (Lorg/apache/tools/zip/ZipOutputStream;Z)V
@@ -476,7 +472,6 @@ public final class com/github/jengelman/gradle/plugins/shadow/transformers/Trans
476472
}
477473

478474
public final class com/github/jengelman/gradle/plugins/shadow/transformers/Transformer$DefaultImpls {
479-
public static fun getName (Lcom/github/jengelman/gradle/plugins/shadow/transformers/Transformer;)Ljava/lang/String;
480475
public static fun getObjectFactory (Lcom/github/jengelman/gradle/plugins/shadow/transformers/Transformer;)Lorg/gradle/api/model/ObjectFactory;
481476
}
482477

src/docs/changes/README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@
1212

1313
- Fix the last modified time of shadowed directories. ([#1277](https://github.com/GradleUp/shadow/pull/1277))
1414

15+
**Removed**
16+
17+
- **BREAKING CHANGE:** Remove `Named` from the parents of `Transformer`. ([#1289](https://github.com/GradleUp/shadow/pull/1289))
18+
1519

1620
## [v9.0.0-beta9] (2025-02-24)
1721

src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/Transformer.kt

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package com.github.jengelman.gradle.plugins.shadow.transformers
33
import com.github.jengelman.gradle.plugins.shadow.relocation.CacheableRelocator
44
import java.io.IOException
55
import org.apache.tools.zip.ZipOutputStream
6-
import org.gradle.api.Named
76
import org.gradle.api.file.FileTreeElement
87
import org.gradle.api.model.ObjectFactory
98
import org.gradle.api.tasks.Internal
@@ -16,7 +15,7 @@ import org.gradle.api.tasks.Internal
1615
* @author John Engelman
1716
*/
1817
@JvmDefaultWithCompatibility
19-
public interface Transformer : Named {
18+
public interface Transformer {
2019
public fun canTransformResource(element: FileTreeElement): Boolean
2120

2221
@Throws(IOException::class)
@@ -27,9 +26,6 @@ public interface Transformer : Named {
2726
@Throws(IOException::class)
2827
public fun modifyOutputStream(os: ZipOutputStream, preserveFileTimestamps: Boolean)
2928

30-
@Internal
31-
override fun getName(): String = this::class.java.simpleName
32-
3329
/**
3430
* This is used for creating Gradle's lazy properties in the subclass, Shadow's build-in transformers that depend on
3531
* this have been injected via [ObjectFactory.newInstance]. Custom transformers should implement or inject

0 commit comments

Comments
 (0)