Remove TODO for excludeProjectFromMinimizeShallNotExcludeTransitiveDependenciesThatAreUsedInSubproject

Goooler · Goooler · commit 6c89a12dc543 · 2025-01-09T21:27:23.000+08:00
diff --git a/src/funcTest/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowPluginTest.kt b/src/funcTest/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowPluginTest.kt
@@ -272,8 +272,6 @@ class ShadowPluginTest : BasePluginTest() {
     )
     run(serverShadowJarTask)
 
-    // TODO: I don't think junit classes should be in the output jar, but it's the test case
-    //  from https://github.com/GradleUp/shadow/pull/420, need to investigate more...
     assertThat(outputServerShadowJar).useAll {
       containsEntries(
         "client/Client.class",

Original file line number	Diff line number	Diff line change
`@@ -272,8 +272,6 @@ class ShadowPluginTest : BasePluginTest() {`
`272`	`272`	`)`
`273`	`273`	`run(serverShadowJarTask)`
`274`	`274`
`275`		`- // TODO: I don't think junit classes should be in the output jar, but it's the test case`
`276`		`- // from https://github.com/GradleUp/shadow/pull/420, need to investigate more...`
`277`	`275`	`assertThat(outputServerShadowJar).useAll {`
`278`	`276`	`containsEntries(`
`279`	`277`	`"client/Client.class",`