With applicationExtension in ShadowApplicationPlugin (#1334)

Author: Goooler

src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowApplicationPlugin.kt

@@ -34,7 +34,6 @@ public abstract class ShadowApplicationPlugin : Plugin<Project> {
   }
 
   protected open fun Project.addRunTask() {
-    val extension = applicationExtension
     tasks.register(SHADOW_RUN_TASK_NAME, JavaExec::class.java) { task ->
       task.description = "Runs this project as a JVM application using the shadow jar"
       task.group = ApplicationPlugin.APPLICATION_GROUP
@@ -43,17 +42,19 @@ public abstract class ShadowApplicationPlugin : Plugin<Project> {
         i.destinationDir.resolve("lib/${s.archiveFile.get().asFile.name}")
       }
       task.classpath(jarFile)
-      task.mainModule.set(extension.mainModule)
-      task.mainClass.set(extension.mainClass)
-      task.jvmArguments.convention(provider { extension.applicationDefaultJvmArgs })
+
+      with(applicationExtension) {
+        task.mainModule.set(mainModule)
+        task.mainClass.set(mainClass)
+        task.jvmArguments.convention(provider { applicationDefaultJvmArgs })
+      }
 
       task.modularity.inferModulePath.convention(javaPluginExtension.modularity.inferModulePath)
       task.javaLauncher.convention(javaToolchainService.launcherFor(javaPluginExtension.toolchain))
     }
   }
 
   protected open fun Project.addCreateScriptsTask() {
-    val extension = applicationExtension
     tasks.register(SHADOW_SCRIPTS_TASK_NAME, CreateStartScripts::class.java) { task ->
       task.description = "Creates OS specific scripts to run the project as a JVM application using the shadow jar"
       task.group = ApplicationPlugin.APPLICATION_GROUP
@@ -65,12 +66,16 @@ public abstract class ShadowApplicationPlugin : Plugin<Project> {
         resources.text.fromString(requireResourceAsText("$dir/windowsStartScript.txt"))
 
       task.classpath = files(tasks.shadowJar)
-      task.mainModule.set(extension.mainModule)
-      task.mainClass.set(extension.mainClass)
-      task.conventionMapping.map("applicationName", extension::getApplicationName)
-      task.conventionMapping.map("outputDir") { layout.buildDirectory.dir("scriptsShadow").get().asFile }
-      task.conventionMapping.map("executableDir", extension::getExecutableDir)
-      task.conventionMapping.map("defaultJvmOpts", extension::getApplicationDefaultJvmArgs)
+
+      with(applicationExtension) {
+        task.mainModule.set(mainModule)
+        task.mainClass.set(mainClass)
+        task.conventionMapping.map("applicationName", ::getApplicationName)
+        task.conventionMapping.map("outputDir") { layout.buildDirectory.dir("scriptsShadow").get().asFile }
+        task.conventionMapping.map("executableDir", ::getExecutableDir)
+        task.conventionMapping.map("defaultJvmOpts", ::getApplicationDefaultJvmArgs)
+      }
+
       task.modularity.inferModulePath.convention(javaPluginExtension.modularity.inferModulePath)
     }
   }