Rename test lifecycle functions (#1727)

Author: Goooler

src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/BasePluginTest.kt

@@ -63,7 +63,7 @@ abstract class BasePluginTest {
   val outputServerShadowedJar: JarPath get() = jarPath("server/build/libs/server-1.0-all.jar")
 
   @BeforeAll
-  open fun doFirst() {
+  fun beforeAll() {
     localRepo = AppendableMavenRepository(
       createTempDirectory().resolve("local-maven-repo").createDirectories(),
       runner(projectDir = null),
@@ -124,18 +124,18 @@ abstract class BasePluginTest {
   }
 
   @BeforeEach
-  open fun setup() {
+  open fun beforeEach() {
     projectScript.writeText(getDefaultProjectBuildScript(withGroup = true, withVersion = true))
     settingsScript.writeText(getDefaultSettingsBuildScript())
   }
 
   @AfterEach
-  fun cleanup() {
+  fun afterEach() {
     println(projectScript.readText())
   }
 
   @AfterAll
-  fun doLast() {
+  fun afterAll() {
     @OptIn(ExperimentalPathApi::class)
     localRepo.root.deleteRecursively()
   }

src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/FilteringTest.kt

@@ -12,8 +12,8 @@ import org.junit.jupiter.params.provider.ValueSource
 
 class FilteringTest : BasePluginTest() {
   @BeforeEach
-  override fun setup() {
-    super.setup()
+  override fun beforeEach() {
+    super.beforeEach()
     projectScript.appendText(
       """
         dependencies {

src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/GroovyPluginTest.kt

@@ -10,8 +10,8 @@ import org.junit.jupiter.api.Test
 
 class GroovyPluginTest : BasePluginTest() {
   @BeforeEach
-  override fun setup() {
-    super.setup()
+  override fun beforeEach() {
+    super.beforeEach()
     val projectBuildScript = getDefaultProjectBuildScript(
       plugin = "groovy",
       withGroup = true,

src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/KotlinPluginsTest.kt

@@ -19,8 +19,8 @@ import org.junit.jupiter.params.provider.ValueSource
 
 class KotlinPluginsTest : BasePluginTest() {
   @BeforeEach
-  override fun setup() {
-    super.setup()
+  override fun beforeEach() {
+    super.beforeEach()
     val projectBuildScript = getDefaultProjectBuildScript(
       plugin = "org.jetbrains.kotlin.multiplatform",
       withGroup = true,

src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/PublishingTest.kt

@@ -54,8 +54,8 @@ class PublishingTest : BasePluginTest() {
   lateinit var remoteRepoPath: Path
 
   @BeforeEach
-  override fun setup() {
-    super.setup()
+  override fun beforeEach() {
+    super.beforeEach()
     settingsScript.appendText("rootProject.name = 'maven'$lineSeparator")
   }
 

src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/ScalaPluginTest.kt

@@ -10,8 +10,8 @@ import org.junit.jupiter.api.Test
 
 class ScalaPluginTest : BasePluginTest() {
   @BeforeEach
-  override fun setup() {
-    super.setup()
+  override fun beforeEach() {
+    super.beforeEach()
     val projectBuildScript = getDefaultProjectBuildScript(
       plugin = "scala",
       withGroup = true,

src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/BaseTransformerTest.kt

@@ -8,8 +8,8 @@ import org.junit.jupiter.api.BeforeEach
 
 abstract class BaseTransformerTest : BasePluginTest() {
   @BeforeEach
-  override fun setup() {
-    super.setup()
+  override fun beforeEach() {
+    super.beforeEach()
     projectScript.appendText(
       """
         $shadowJarTask {

src/test/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/BaseTransformerTest.kt

@@ -23,7 +23,7 @@ abstract class BaseTransformerTest<T : ResourceTransformer> {
     get() = TransformerContext(MANIFEST_NAME, requireResourceAsStream(MANIFEST_NAME))
 
   @BeforeEach
-  open fun setup() {
+  open fun beforeEach() {
     @Suppress("UNCHECKED_CAST")
     val clazz = (this::class.java.genericSuperclass as ParameterizedType).actualTypeArguments.first() as Class<T>
     transformer = clazz.create(testObjectFactory)

src/test/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/ServiceFileTransformerTest.kt

@@ -27,13 +27,13 @@ class ServiceFileTransformerTest : BaseTransformerTest<ServiceFileTransformer>()
   private lateinit var tempJar: Path
 
   @BeforeEach
-  override fun setup() {
-    super.setup()
+  override fun beforeEach() {
+    super.beforeEach()
     tempJar = createTempFile("shade.", ".jar")
   }
 
   @AfterEach
-  fun cleanup() {
+  fun afterEach() {
     tempJar.deleteExisting()
   }