Replace shadow names in functional tests (#1269)

* Write test main classes to my packages by default

* Replace other shadow packages

* Replace groups for artifacts a, b, c, and d

* Replace project names

Author: Goooler

src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/ApplicationPluginTest.kt

@@ -73,7 +73,7 @@ class ApplicationPluginTest : BasePluginTest() {
 
     commonAssertions(
       jarPath("myapp-shadow/lib/myapp-1.0-all.jar", installPath),
-      entriesContained = arrayOf("shadow/Main.class", "junit/framework/Test.class"),
+      entriesContained = arrayOf("my/Main.class", "junit/framework/Test.class"),
     )
 
     val unixScript = path("myapp-shadow/bin/myapp", installPath)
@@ -119,7 +119,7 @@ class ApplicationPluginTest : BasePluginTest() {
       projectBlock = """
         shadowJar {
           manifest {
-            attributes '$mainClassAttributeKey': 'shadow.Main2'
+            attributes '$mainClassAttributeKey': 'my.Main2'
           }
         }
       """.trimIndent(),
@@ -135,8 +135,8 @@ class ApplicationPluginTest : BasePluginTest() {
     assertions(run(runShadowTask).output, "foo")
     commonAssertions(
       jarPath("build/install/myapp-shadow/lib/myapp-1.0-all.jar"),
-      entriesContained = entriesInA + arrayOf("shadow/Main.class", "shadow/Main2.class"),
-      mainClassAttr = "shadow.Main2",
+      entriesContained = entriesInA + arrayOf("my/Main.class", "my/Main2.class"),
+      mainClassAttr = "my.Main2",
     )
 
     projectScriptPath.appendText(
@@ -213,7 +213,7 @@ class ApplicationPluginTest : BasePluginTest() {
     projectBlock: String = "",
     applicationBlock: String = "",
     settingsBlock: String = "",
-    dependenciesBlock: String = "implementation 'shadow:a:1.0'",
+    dependenciesBlock: String = "implementation 'my:a:1.0'",
     runShadowBlock: String = "",
   ) {
     writeMainClass(withImports = mainClassWithImports)
@@ -222,7 +222,7 @@ class ApplicationPluginTest : BasePluginTest() {
         apply plugin: 'application'
         $projectBlock
         application {
-          mainClass = 'shadow.Main'
+          mainClass = 'my.Main'
           $applicationBlock
         }
         dependencies {
@@ -244,8 +244,8 @@ class ApplicationPluginTest : BasePluginTest() {
 
   private fun commonAssertions(
     jarPath: JarPath,
-    entriesContained: Array<String> = entriesInA + "shadow/Main.class",
-    mainClassAttr: String = "shadow.Main",
+    entriesContained: Array<String> = entriesInA + "my/Main.class",
+    mainClassAttr: String = "my.Main",
     classPathAttr: String? = null,
   ) {
     assertThat(jarPath).useAll {

src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/BasePluginTest.kt

@@ -57,19 +57,19 @@ abstract class BasePluginTest {
     )
     localRepo.module("junit", "junit", "3.8.2") {
       useJar(junitJar)
-    }.module("shadow", "a", "1.0") {
+    }.module("my", "a", "1.0") {
       buildJar {
         insert("a.properties", "a")
         insert("a2.properties", "a2")
       }
-    }.module("shadow", "b", "1.0") {
+    }.module("my", "b", "1.0") {
       buildJar {
         insert("b.properties", "b")
       }
     }.publish()
 
-    artifactAJar = path("shadow/a/1.0/a-1.0.jar", parent = localRepo.root)
-    artifactBJar = path("shadow/b/1.0/b-1.0.jar", parent = localRepo.root)
+    artifactAJar = path("my/a/1.0/a-1.0.jar", parent = localRepo.root)
+    artifactBJar = path("my/b/1.0/b-1.0.jar", parent = localRepo.root)
     entriesInA = arrayOf("a.properties", "a2.properties")
     entriesInB = arrayOf("b.properties")
     entriesInAB = entriesInA + entriesInB
@@ -98,15 +98,15 @@ abstract class BasePluginTest {
 
   val projectScriptPath: Path get() = path("build.gradle")
   val settingsScriptPath: Path get() = path("settings.gradle")
-  open val outputShadowJar: JarPath get() = jarPath("build/libs/shadow-1.0-all.jar")
+  open val outputShadowJar: JarPath get() = jarPath("build/libs/my-1.0-all.jar")
   val outputServerShadowJar: JarPath get() = jarPath("server/build/libs/server-1.0-all.jar")
 
   fun getDefaultProjectBuildScript(
     javaPlugin: String = "java",
     withGroup: Boolean = false,
     withVersion: Boolean = false,
   ): String {
-    val groupInfo = if (withGroup) "group = 'shadow'" else ""
+    val groupInfo = if (withGroup) "group = 'my'" else ""
     val versionInfo = if (withVersion) "version = '1.0'" else ""
     return """
       plugins {
@@ -124,7 +124,7 @@ abstract class BasePluginTest {
     // this test, and we won't accidentally use cached outputs from a different test or a different build.
     // https://docs.gradle.org/current/userguide/build_cache.html#sec:build_cache_configure_local
     buildCacheBlock: String = "local { directory = file('build-cache') }",
-    endBlock: String = "rootProject.name = 'shadow'",
+    endBlock: String = "rootProject.name = 'my'",
   ): String {
     return """
       $startBlock
@@ -173,31 +173,32 @@ abstract class BasePluginTest {
   }
 
   fun publishArtifactCD(circular: Boolean = false) {
-    localRepo.module("shadow", "c", "1.0") {
+    localRepo.module("my", "c", "1.0") {
       buildJar {
         insert("c.properties", "c")
       }
       if (circular) {
-        addDependency("shadow", "d", "1.0")
+        addDependency("my", "d", "1.0")
       }
-    }.module("shadow", "d", "1.0") {
+    }.module("my", "d", "1.0") {
       buildJar {
         insert("d.properties", "d")
       }
-      addDependency("shadow", "c", "1.0")
+      addDependency("my", "c", "1.0")
     }.publish()
   }
 
   fun writeMainClass(
     sourceSet: String = "main",
+    packageName: String = "my",
     withImports: Boolean = false,
     className: String = "Main",
   ) {
     val imports = if (withImports) "import junit.framework.Test;" else ""
     val classRef = if (withImports) "\"Refs: \" + Test.class.getName()" else "\"Refs: null\""
-    path("src/$sourceSet/java/shadow/$className.java").writeText(
+    path("src/$sourceSet/java/$packageName/$className.java").writeText(
       """
-        package shadow;
+        package $packageName;
         $imports
         public class $className {
           public static void main(String[] args) {

src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/FilteringTest.kt

@@ -24,8 +24,8 @@ class FilteringTest : BasePluginTest() {
     projectScriptPath.appendText(
       """
         dependencies {
-          implementation 'shadow:a:1.0'
-          implementation 'shadow:b:1.0'
+          implementation 'my:a:1.0'
+          implementation 'my:b:1.0'
         }
       """.trimIndent() + System.lineSeparator(),
     )
@@ -76,11 +76,11 @@ class FilteringTest : BasePluginTest() {
     projectScriptPath.appendText(
       """
         dependencies {
-          implementation 'shadow:d:1.0'
+          implementation 'my:d:1.0'
         }
         $shadowJar {
           dependencies {
-            exclude(dependency('shadow:d:.*'))
+            exclude(dependency('my:d:.*'))
           }
         }
       """.trimIndent(),
@@ -100,7 +100,7 @@ class FilteringTest : BasePluginTest() {
     commonAssertions()
 
     val replaced = projectScriptPath.readText()
-      .replace("exclude(dependency('shadow:d:1.0'))", "exclude(dependency('shadow:c:1.0'))")
+      .replace("exclude(dependency('my:d:1.0'))", "exclude(dependency('my:c:1.0'))")
     projectScriptPath.writeText(replaced)
     val result = run(shadowJarTask)
 
@@ -123,7 +123,7 @@ class FilteringTest : BasePluginTest() {
     commonAssertions()
 
     val replaced = projectScriptPath.readText()
-      .replace("exclude(dependency('shadow:d:1.0'))", "exclude 'a.properties'")
+      .replace("exclude(dependency('my:d:1.0'))", "exclude 'a.properties'")
     projectScriptPath.writeText(replaced)
 
     val result = run(shadowJarTask)
@@ -147,18 +147,18 @@ class FilteringTest : BasePluginTest() {
     projectScriptPath.appendText(
       """
         dependencies {
-          implementation 'shadow:d:1.0'
+          implementation 'my:d:1.0'
         }
         $shadowJar {
           dependencies {
-            include(dependency('shadow:d:1.0'))
+            include(dependency('my:d:1.0'))
           }
         }
       """.trimIndent(),
     )
-    path("src/main/java/shadow/Passed.java").writeText(
+    path("src/main/java/my/Passed.java").writeText(
       """
-        package shadow;
+        package my;
         public class Passed {}
       """.trimIndent(),
     )
@@ -168,7 +168,7 @@ class FilteringTest : BasePluginTest() {
     assertThat(outputShadowJar).useAll {
       containsEntries(
         "d.properties",
-        "shadow/Passed.class",
+        "my/Passed.class",
       )
       val entries = entriesInAB + "c.properties"
       doesNotContainEntries(*entries)
@@ -260,11 +260,11 @@ class FilteringTest : BasePluginTest() {
     projectScriptPath.appendText(
       """
         dependencies {
-          implementation 'shadow:d:1.0'
+          implementation 'my:d:1.0'
         }
         $shadowJar {
           dependencies {
-            exclude(dependency('shadow:d:1.0'))
+            exclude(dependency('my:d:1.0'))
           }
         }
       """.trimIndent(),