Eliminate convention plugin (#1398)

Author: Goooler

build-logic/build.gradle.kts

@@ -1,14 +1,30 @@
 @file:Suppress("UnstableApiUsage")
 
+import org.gradle.api.plugins.JavaPlugin.API_ELEMENTS_CONFIGURATION_NAME
+import org.gradle.api.plugins.JavaPlugin.JAVADOC_ELEMENTS_CONFIGURATION_NAME
+import org.gradle.api.plugins.JavaPlugin.RUNTIME_ELEMENTS_CONFIGURATION_NAME
+import org.gradle.api.plugins.JavaPlugin.SOURCES_ELEMENTS_CONFIGURATION_NAME
 import org.jetbrains.kotlin.gradle.dsl.JvmTarget
 import org.jetbrains.kotlin.gradle.dsl.KotlinVersion
 
 plugins {
   alias(libs.plugins.kotlin.jvm)
   alias(libs.plugins.android.lint)
   alias(libs.plugins.jetbrains.bcv)
+  alias(libs.plugins.jetbrains.dokka)
+  alias(libs.plugins.mavenPublish)
+  alias(libs.plugins.pluginPublish)
   alias(libs.plugins.spotless)
-  id("shadow.convention.publish")
+}
+
+version = providers.gradleProperty("VERSION_NAME").get()
+group = providers.gradleProperty("GROUP").get()
+description = providers.gradleProperty("POM_DESCRIPTION").get()
+
+dokka {
+  dokkaPublications.html {
+    outputDirectory = rootDir.resolve("docs/api")
+  }
 }
 
 java {
@@ -40,15 +56,43 @@ spotless {
   }
   kotlinGradle {
     ktlint(libs.ktlint.get().version)
-    target("**/*.kts")
-    targetExclude("build-logic/build/**")
   }
 }
 
 val testPluginClasspath by configurations.registering {
   isCanBeResolved = true
 }
 
+configurations.configureEach {
+  when (name) {
+    API_ELEMENTS_CONFIGURATION_NAME,
+    RUNTIME_ELEMENTS_CONFIGURATION_NAME,
+    JAVADOC_ELEMENTS_CONFIGURATION_NAME,
+    SOURCES_ELEMENTS_CONFIGURATION_NAME,
+    -> {
+      outgoing {
+        // Main/current capability.
+        capability("com.gradleup.shadow:shadow-gradle-plugin:$version")
+
+        // Historical capabilities.
+        capability("io.github.goooler.shadow:shadow-gradle-plugin:$version")
+        capability("com.github.johnrengelman:shadow:$version")
+        capability("gradle.plugin.com.github.jengelman.gradle.plugins:shadow:$version")
+        capability("gradle.plugin.com.github.johnrengelman:shadow:$version")
+        capability("com.github.jengelman.gradle.plugins:shadow:$version")
+      }
+    }
+  }
+}
+
+publishing.publications.withType<MavenPublication>().configureEach {
+  // We don't care about capabilities being unmappable to Maven.
+  suppressPomMetadataWarningsFor(API_ELEMENTS_CONFIGURATION_NAME)
+  suppressPomMetadataWarningsFor(RUNTIME_ELEMENTS_CONFIGURATION_NAME)
+  suppressPomMetadataWarningsFor(JAVADOC_ELEMENTS_CONFIGURATION_NAME)
+  suppressPomMetadataWarningsFor(SOURCES_ELEMENTS_CONFIGURATION_NAME)
+}
+
 dependencies {
   compileOnly(libs.kotlin.kmp)
   implementation(libs.apache.ant)
@@ -61,8 +105,8 @@ dependencies {
   implementation(libs.plexus.xml)
 
   testPluginClasspath(libs.foojayResolver)
-  testPluginClasspath(libs.pluginPublish)
   testPluginClasspath(libs.kotlin.kmp)
+  testPluginClasspath(libs.pluginPublish)
 
   lintChecks(libs.androidx.gradlePluginLints)
 }
@@ -124,6 +168,26 @@ testing.suites {
   }
 }
 
+gradlePlugin {
+  website = providers.gradleProperty("POM_URL")
+  vcsUrl = providers.gradleProperty("POM_URL")
+
+  plugins {
+    create("shadowPlugin") {
+      id = "com.gradleup.shadow"
+      implementationClass = "com.github.jengelman.gradle.plugins.shadow.ShadowPlugin"
+      displayName = providers.gradleProperty("POM_NAME").get()
+      description = providers.gradleProperty("POM_DESCRIPTION").get()
+      tags = listOf("onejar", "shade", "fatjar", "uberjar")
+    }
+  }
+
+  testSourceSets(
+    sourceSets["functionalTest"],
+    sourceSets["documentTest"],
+  )
+}
+
 // This part should be placed after testing.suites to ensure the test sourceSets are created.
 kotlin.target.compilations {
   val main by getting
@@ -133,13 +197,6 @@ kotlin.target.compilations {
   }
 }
 
-gradlePlugin {
-  testSourceSets(
-    sourceSets["functionalTest"],
-    sourceSets["documentTest"],
-  )
-}
-
 tasks.pluginUnderTestMetadata {
   // Plugins used in tests could be resolved in classpath.
   pluginClasspath.from(
@@ -174,13 +231,9 @@ tasks.register<Copy>("downloadStartScripts") {
 }
 
 tasks.clean {
-  val includedBuilds = gradle.includedBuilds
-  dependsOn(includedBuilds.map { it.task(path) })
-
-  val rootDirs = includedBuilds.map { it.projectDir } + projectDir
   delete += listOf(
-    rootDirs.map { it.resolve(".gradle") },
-    rootDirs.map { it.resolve(".kotlin") },
+    projectDir.resolve(".gradle"),
+    projectDir.resolve(".kotlin"),
     dokka.dokkaPublications.html.map { it.outputDirectory },
     // Generated by MkDocs.
     rootDir.resolve("site"),

build-logic/gradle.properties

@@ -1,6 +1,7 @@
 [versions]
 kotlin = "2.1.20"
 moshi = "1.15.2"
+pluginPublish = "1.3.1"
 
 [libraries]
 apache-ant = "org.apache.ant:ant:1.10.15"
@@ -17,11 +18,9 @@ xmlunit = "org.xmlunit:xmlunit-legacy:2.10.0"
 moshi = { module = "com.squareup.moshi:moshi", version.ref = "moshi" }
 moshi-kotlin = { module = "com.squareup.moshi:moshi-kotlin", version.ref = "moshi" }
 
-pluginPublish = "com.gradle.publish:plugin-publish-plugin:1.3.1"
-mavenPublish = "com.vanniktech:gradle-maven-publish-plugin:0.31.0"
-jetbrains-dokka = "org.jetbrains.dokka:dokka-gradle-plugin:2.0.0"
 foojayResolver = "org.gradle.toolchains.foojay-resolver-convention:org.gradle.toolchains.foojay-resolver-convention.gradle.plugin:0.10.0"
 kotlin-kmp = { module = "org.jetbrains.kotlin.multiplatform:org.jetbrains.kotlin.multiplatform.gradle.plugin", version.ref = "kotlin" }
+pluginPublish = { module = "com.gradle.publish:plugin-publish-plugin", version.ref = "pluginPublish" }
 
 androidx-gradlePluginLints = "androidx.lint:lint-gradle:1.0.0-alpha03"
 # Dummy to get renovate updates, the version is used in rootProject build.gradle with spotless.
@@ -34,4 +33,7 @@ assertk = "com.willowtreeapps.assertk:assertk:0.28.1"
 kotlin-jvm = { id = "org.jetbrains.kotlin.jvm", version.ref = "kotlin" }
 android-lint = "com.android.lint:8.9.1"
 jetbrains-bcv = "org.jetbrains.kotlinx.binary-compatibility-validator:0.17.0"
+jetbrains-dokka = "org.jetbrains.dokka:2.0.0"
+mavenPublish = "com.vanniktech.maven.publish:0.31.0"
+pluginPublish = { id = "com.gradle.plugin-publish", version.ref = "pluginPublish" }
 spotless = "com.diffplug.spotless:7.0.3"

build-logic/settings.gradle.kts

@@ -10,8 +10,6 @@ pluginManagement {
     }
     gradlePluginPortal()
   }
-
-  includeBuild("build-logic")
 }
 
 plugins {