Deprecate InheritManifest (#1722)

* Try to remove `InheritManifest`

* Revert "Try to remove `InheritManifest`"

This reverts commit 1a0745d.

* Mark `Deprecated`

* Update changelog

Author: Goooler

docs/changes/README.md

@@ -15,6 +15,7 @@
   The Gradle Module descriptors (`org.codehaus.groovy.runtime.ExtensionModule` files) defined under `META-INF/services/`
   and `META-INF/groovy` will be merged into `META-INF/groovy/org.codehaus.groovy.runtime.ExtensionModule`.
 - Move injecting `Class-Path` manifest attr logic from `doFirst` into `copy`. ([#1720](https://github.com/GradleUp/shadow/pull/1720))
+- Deprecate `InheritManifest`. ([#1722](https://github.com/GradleUp/shadow/pull/1722))
 
 ### Fixed
 

src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/DefaultInheritManifest.kt

@@ -1,3 +1,5 @@
+@file:Suppress("DEPRECATION")
+
 package com.github.jengelman.gradle.plugins.shadow.internal
 
 import com.github.jengelman.gradle.plugins.shadow.tasks.InheritManifest

src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/InheritManifest.kt

@@ -4,6 +4,10 @@ import org.gradle.api.Action
 import org.gradle.api.java.archives.Manifest
 import org.gradle.api.java.archives.ManifestMergeSpec
 
+@Deprecated(
+  message = "This is deprecated and will be removed in a future release. `inheritFrom` should be replaced by `from`.",
+  replaceWith = ReplaceWith("Manifest", "org.gradle.api.java.archives.Manifest"),
+)
 public interface InheritManifest : Manifest {
   public fun inheritFrom(vararg inheritPaths: Any) {
     inheritFrom(inheritPaths = inheritPaths, action = {})

src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt

@@ -195,6 +195,7 @@ public abstract class ShadowJar : Jar() {
   @get:Option(option = "add-multi-release-attribute", description = "Adds the multi-release attribute to the manifest if any dependencies contain it.")
   public open val addMultiReleaseAttribute: Property<Boolean> = objectFactory.property(true)
 
+  @Suppress("DEPRECATION") // TODO: replace the usage of deprecated InheritManifest.
   @Internal
   override fun getManifest(): InheritManifest = super.getManifest() as InheritManifest