Working on next version

Author: GrahamCampbell

src/Auth/Authenticator/AbstractAuthenticator.php

@@ -23,11 +23,6 @@
  */
 abstract class AbstractAuthenticator implements AuthenticatorInterface
 {
-    /**
-     * The client to perform the authentication on.
-     *
-     * @var \Github\Client|null
-     */
     private ?Client $client = null;
 
     /**

src/Auth/AuthenticatorFactory.php

@@ -36,10 +36,10 @@ public function make(string $method): AuthenticatorInterface
     {
         return match ($method) {
             'application' => new Authenticator\ApplicationAuthenticator(),
-            'jwt' => new Authenticator\JwtAuthenticator(),
-            'private' => new Authenticator\PrivateKeyAuthenticator(),
-            'token' => new Authenticator\TokenAuthenticator(),
-            default => throw new InvalidArgumentException("Unsupported authentication method [$method]."),
+            'jwt'         => new Authenticator\JwtAuthenticator(),
+            'private'     => new Authenticator\PrivateKeyAuthenticator(),
+            'token'       => new Authenticator\TokenAuthenticator(),
+            default       => throw new InvalidArgumentException("Unsupported authentication method [$method]."),
         };
     }
 }

src/Cache/ConnectionFactory.php

@@ -25,23 +25,16 @@
  */
 class ConnectionFactory
 {
-    /**
-     * The cache factory instance.
-     *
-     * @var \Illuminate\Contracts\Cache\Factory|null
-     */
-    private ?Factory $cache;
-
     /**
      * Create a new connection factory instance.
      *
      * @param \Illuminate\Contracts\Cache\Factory|null $cache
      *
      * @return void
      */
-    public function __construct(?Factory $cache = null)
-    {
-        $this->cache = $cache;
+    public function __construct(
+        private readonly Factory $cache = null,
+    ) {
     }
 
     /**

src/Cache/Connector/IlluminateConnector.php

@@ -28,37 +28,19 @@
  */
 final class IlluminateConnector implements ConnectorInterface
 {
-    /**
-     * The minimum cache lifetime of 12 hours.
-     *
-     * @var int
-     */
     private const MIN_CACHE_LIFETIME = 43200;
-
-    /**
-     * The maximum cache lifetime of 48 hours.
-     *
-     * @var int
-     */
     private const MAX_CACHE_LIFETIME = 172800;
 
-    /**
-     * The cache factory instance.
-     *
-     * @var \Illuminate\Contracts\Cache\Factory|null
-     */
-    private ?Factory $cache;
-
     /**
      * Create a new illuminate connector instance.
      *
      * @param \Illuminate\Contracts\Cache\Factory|null $cache
      *
      * @return void
      */
-    public function __construct(?Factory $cache = null)
-    {
-        $this->cache = $cache;
+    public function __construct(
+        private readonly ?Factory $cache = null,
+    ) {
     }
 
     /**

src/GitHubFactory.php

@@ -31,27 +31,6 @@
  */
 class GitHubFactory
 {
-    /**
-     * The http client builder factory instance.
-     *
-     * @var \GrahamCampbell\GitHub\HttpClient\BuilderFactory
-     */
-    private BuilderFactory $builder;
-
-    /**
-     * The authenticator factory instance.
-     *
-     * @var \GrahamCampbell\GitHub\Auth\AuthenticatorFactory
-     */
-    private AuthenticatorFactory $auth;
-
-    /**
-     * The cache factory instance.
-     *
-     * @var \GrahamCampbell\GitHub\Cache\ConnectionFactory
-     */
-    private ConnectionFactory $cache;
-
     /**
      * Create a new github factory instance.
      *
@@ -61,11 +40,11 @@ class GitHubFactory
      *
      * @return void
      */
-    public function __construct(BuilderFactory $builder, AuthenticatorFactory $auth, ConnectionFactory $cache)
-    {
-        $this->builder = $builder;
-        $this->auth = $auth;
-        $this->cache = $cache;
+    public function __construct(
+        private readonly BuilderFactory $builder,
+        private readonly AuthenticatorFactory $auth,
+        private readonly ConnectionFactory $cache,
+    ) {
     }
 
     /**

src/GitHubManager.php

@@ -83,12 +83,7 @@
  */
 class GitHubManager extends AbstractManager
 {
-    /**
-     * The factory instance.
-     *
-     * @var \GrahamCampbell\GitHub\GitHubFactory
-     */
-    protected GitHubFactory $factory;
+    protected readonly GitHubFactory $factory;
 
     /**
      * Create a new github manager instance.

src/HttpClient/BuilderFactory.php

@@ -25,27 +25,6 @@
  */
 class BuilderFactory
 {
-    /**
-     * The http client instance.
-     *
-     * @var \Psr\Http\Client\ClientInterface
-     */
-    private ClientInterface $httpClient;
-
-    /**
-     * The request factory instance.
-     *
-     * @var \Psr\Http\Message\RequestFactoryInterface
-     */
-    private RequestFactoryInterface $requestFactory;
-
-    /**
-     * The stream factory instance.
-     *
-     * @var \Psr\Http\Message\StreamFactoryInterface
-     */
-    private StreamFactoryInterface $streamFactory;
-
     /**
      * Create a new connection factory instance.
      *
@@ -55,11 +34,11 @@ class BuilderFactory
      *
      * @return void
      */
-    public function __construct(ClientInterface $httpClient, RequestFactoryInterface $requestFactory, StreamFactoryInterface $streamFactory)
-    {
-        $this->httpClient = $httpClient;
-        $this->requestFactory = $requestFactory;
-        $this->streamFactory = $streamFactory;
+    public function __construct(
+        private readonly ClientInterface $httpClient,
+        private readonly RequestFactoryInterface $requestFactory,
+        private readonly StreamFactoryInterface $streamFactory,
+    ) {
     }
 
     /**