Skip to content

Commit ec5e681

Browse files
GramGra07gitbook-bot
authored andcommitted
GITBOOK-25: No subject
1 parent 01d3f3b commit ec5e681

File tree

7 files changed

+27
-10
lines changed

7 files changed

+27
-10
lines changed

.etc/code-review.md

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
---
2+
description: >-
3+
Code reviews are a handy way of making sure all your code works by asking
4+
alumni to "approve" and comment on it with little overhead.
5+
---
6+
7+
# Code Review
8+
9+
If you want to do code reviews with me, please DM me over Discord or email.
10+
11+
12+
13+
Here are general instructions on getting your GitHub repo ready for a code review.
14+
15+
1. Add my github account as a collaborator on your repository (GramGra07)
16+
2. Add a branch rulset
17+
1. ![](<../.gitbook/assets/Screenshot 2025-01-26 184029.png>)
18+
2. ![](<../.gitbook/assets/Screenshot 2025-01-26 183915.png>)
19+
3. Leave the ones that are already selected on the rulset
20+
3. Create a new branch
21+
1. ![](<../.gitbook/assets/Screenshot 2025-01-26 184132.png>)
22+
4. Create the "code review"/pull request
23+
1. ![](<../.gitbook/assets/Screenshot 2025-01-26 184558.png>)
24+
2. Add my account as a reviewer with the settings bar and make sure it is merging from the new branch to master/main
25+
3. Push the pull request and review the comments I leave on it!
26+
67.9 KB
Loading
51.3 KB
Loading
16.1 KB
Loading
71.3 KB
Loading

SUMMARY.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# Table of contents
22

33
* [WHS-FTC Code\_Training\_Module](README.md)
4-
* [WHS\_Robotics Specific](whs_robotics-specific.md)
54
* [Presented at Worlds 2024](presented-at-worlds-2024.md)
65
* [Getting Started with Programming](githubbasics.md)
76
* [How does everything work?](how-does-everything-work.md)
@@ -35,3 +34,4 @@
3534
* [.etc](.etc/README.md)
3635
* [Machine learning](.etc/machinelearning.md)
3736
* [linksAndAcknowledgements](.etc/linksandacknowledgements.md)
37+
* [Code Review](.etc/code-review.md)

whs_robotics-specific.md

Lines changed: 0 additions & 9 deletions
This file was deleted.

0 commit comments

Comments
 (0)