Implemented duplication of a panel by right-click in the organ tree. Don't write sharp key width if not necessary. Also check tremulants for switch usage/references.

Author: larspalo

CHANGELOG.md

@@ -10,7 +10,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 
 - Option to create new panel from selection on existing panel display. (TODO)
-- Option to duplicate an existing panel. (TODO)
+
+## [0.15.0] - 2024-07-27
+
+### Added
+
+- Option to duplicate an existing panel by right-clicking on it in the organ tree.
 - Setter element CrescendoOverride.
 
 ### Fixed
@@ -24,6 +29,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Issue/Bug on the msw port in the PipeDialog that would cause forcing selection of IsPercussive=Y when navigating with "Next" button to the last pipe
 - Direct right-click on a pipe in rank pipe tree that previously didn't create a true selection of a pipe in the msw port.
 - Restore focus to main window after opening an .organ file on the msw port (make sure it's raised).
+- Not writing Key999Width for sharps when not necessary (could potentially mess up the layout of keys).
+- Take tremulants into accound when checking if a switch is referenced anywhere.
 
 ## [0.14.0] - 2024-07-02
 

src/GOODFFrame.cpp

@@ -1402,6 +1402,56 @@ void GOODFFrame::OnOrganTreeRightClicked(wxTreeEvent& event) {
 		event.Skip();
 		return;
 	}
+
+	if (parentId == tree_panels) {
+		// A panel was right clicked, should it be duplicated?
+		if (m_organ->getNumberOfPanels() < 1000) {
+			wxMessageDialog dlg(this, wxT("Do you want to duplicate the right-clicked panel?"), wxT("Duplicate panel?"), wxYES_NO|wxCENTRE);
+			if (dlg.ShowModal() == wxID_YES) {
+				int selectedPanelIndex = 0;
+				int numPanels = m_organTreeCtrl->GetChildrenCount(tree_panels, false);
+				wxTreeItemIdValue cookie;
+				for (int i = 0; i < numPanels; i++) {
+					wxTreeItemId currentId;
+					if (i == 0)
+						currentId = m_organTreeCtrl->GetFirstChild(tree_panels, cookie);
+					else
+						currentId = m_organTreeCtrl->GetNextChild(tree_panels, cookie);
+					if (clickedId == currentId)
+						selectedPanelIndex = i;
+				}
+
+				GoPanel p = *(m_organ->getOrganPanelAt(selectedPanelIndex));
+				m_organ->addPanel(p);
+				wxTreeItemId thisPanel = m_organTreeCtrl->AppendItem(tree_panels, p.getName());
+				// create the subitems for Displaymetrics, Images and GUIElements
+				m_organTreeCtrl->AppendItem(thisPanel, wxT("Displaymetrics"));
+				wxTreeItemId panelImages = m_organTreeCtrl->AppendItem(thisPanel, wxT("Images"));
+				for (unsigned i = 0; i < p.getNumberOfImages(); i++) {
+					wxString displayName = p.getImageAt(i)->getImageNameOnly();
+					if (displayName == wxEmptyString)
+						displayName = wxT("New Image");
+					m_organTreeCtrl->AppendItem(panelImages, displayName);
+				}
+				wxTreeItemId panelGuiElements = m_organTreeCtrl->AppendItem(thisPanel, wxT("GUI Elements"));
+				for (int i = 0; i < p.getNumberOfGuiElements(); i++) {
+					m_organTreeCtrl->AppendItem(panelGuiElements, p.getGuiElementAt(i)->getDisplayName());
+				}
+				m_organ->setModified(true);
+				m_organTreeCtrl->SelectItem(thisPanel);
+
+			} else {
+				event.Skip();
+				return;
+			}
+		} else {
+			wxMessageDialog msg(this, wxT("Organ cannot have more than 1000 panels!"), wxT("Too many panels"), wxOK|wxCENTRE|wxICON_EXCLAMATION);
+			msg.ShowModal();
+			event.Skip();
+			return;
+		}
+	}
+
 	wxTreeItemId grandParentId = m_organTreeCtrl->GetItemParent(parentId);
 	if (grandParentId != tree_organ && m_organTreeCtrl->GetItemParent(grandParentId) == tree_panels) {
 		int selectedIndex = 0;

src/GUIButton.cpp

@@ -311,6 +311,11 @@ void GUIButton::read(wxFileConfig *cfg, bool isPiston, Organ *readOrgan) {
 		setTextBreakWidth(0);
 }
 
+
+GUIButton* GUIButton::clone() {
+	return new GUIButton(*this);
+}
+
 void GUIButton::updateDisplayName() {
 
 }

src/GUIButton.h

@@ -37,6 +37,7 @@ class GUIButton : public GUIElement {
 	virtual void write(wxTextFile *outFile);
 	virtual void read(wxFileConfig *cfg, bool isPiston, Organ *readOrgan);
 
+	virtual GUIButton* clone();
 	virtual void updateDisplayName();
 	virtual wxBitmap getBitmap();
 	virtual wxString getElementName();

src/GUICoupler.cpp

@@ -45,6 +45,10 @@ void GUICoupler::write(wxTextFile *outFile) {
 	GUIButton::write(outFile);
 }
 
+GUICoupler* GUICoupler::clone() {
+	return new GUICoupler(*this);
+}
+
 bool GUICoupler::isReferencing(Coupler *cplr) {
 	return m_coupler == cplr ? true : false;
 }

src/GUICoupler.h

@@ -32,6 +32,7 @@ class GUICoupler : public GUIButton {
 	~GUICoupler();
 
 	void write(wxTextFile *outFile);
+	virtual GUICoupler* clone();
 	bool isReferencing(Coupler *cplr);
 	void updateDisplayName();
 	wxString getElementName();

src/GUIDivisional.cpp

@@ -48,6 +48,10 @@ void GUIDivisional::write(wxTextFile *outFile) {
 	GUIButton::write(outFile);
 }
 
+GUIDivisional* GUIDivisional::clone() {
+	return new GUIDivisional(*this);
+}
+
 bool GUIDivisional::isReferencing(Divisional *divisional) {
 	return m_divisional == divisional ? true : false;
 }

src/GUIDivisional.h

@@ -32,6 +32,7 @@ class GUIDivisional : public GUIButton {
 	~GUIDivisional();
 
 	void write(wxTextFile *outFile);
+	virtual GUIDivisional* clone();
 	bool isReferencing(Divisional *divisional);
 	void updateDisplayName();
 	wxString getElementName();

src/GUIDivisionalCoupler.cpp

@@ -42,6 +42,10 @@ void GUIDivisionalCoupler::write(wxTextFile *outFile) {
 	GUIButton::write(outFile);
 }
 
+GUIDivisionalCoupler* GUIDivisionalCoupler::clone() {
+	return new GUIDivisionalCoupler(*this);
+}
+
 bool GUIDivisionalCoupler::isReferencing(DivisionalCoupler *divCplr) {
 	return m_divCoupler == divCplr ? true : false;
 }

src/GUIDivisionalCoupler.h

@@ -32,6 +32,7 @@ class GUIDivisionalCoupler : public GUIButton {
 	~GUIDivisionalCoupler();
 
 	void write(wxTextFile *outFile);
+	virtual GUIDivisionalCoupler* clone();
 	bool isReferencing(DivisionalCoupler *divisional);
 	void updateDisplayName();
 	wxString getElementName();