Replies: 1 comment
-
Well, yeah it sounds correct but the problem here is const editor = grapesjs.init(...);
editor.on('log:error', ...) |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
So currently the logging calls happen in the editor model class, which in not the best architecture decision,
because some classes need acquire the editor model just for the logging purposes which could have done whit an include.
So I proposing to move these functions to a separate logging class in the utils dir.
I can make the pr just first I wanted to discuss this.
Beta Was this translation helpful? Give feedback.
All reactions