Skip to content

Commit 6bee9af

Browse files
cleanup: rename FIXMEs to TODO, and remove some that are now resolved
1 parent 65e1561 commit 6bee9af

32 files changed

+74
-96
lines changed

experimental/algorithm/LAGr_EdgeBetweennessCentrality.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,7 @@ int LAGr_EdgeBetweennessCentrality
429429
t3 = LAGraph_WallClockTime() - t3;
430430
t3_total += t3;
431431
#else
432-
// FIXME: Approx update using ewise add not implemented
432+
// TODO: Approx update using ewise add not implemented
433433
// centrality = centrality + Update using eWiseAdd
434434
double t3 = LAGraph_WallClockTime();
435435
GRB_TRY (GrB_eWiseAdd (*centrality, NULL, NULL, GrB_PLUS_FP64, *centrality, Update, NULL));

experimental/algorithm/LAGr_MarkovClustering.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
//------------------------------------------------------------------------------
1717

18-
// FIXME: ready to consider for src
18+
// TODO: ready to consider for src
1919

2020
#define LG_FREE_WORK \
2121
{ \

experimental/algorithm/LAGr_MaximumMatching.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ void minparent(vertex *z, const vertex *x, const vertex *y)
8080
" *z = x->parentC < y->parentC ? *x : *y; \n" \
8181
"}"
8282

83-
// FIXME: revise GraphBLAS so we can tell it that the select2nd operator
83+
// TODO: revise GraphBLAS so we can tell it that the select2nd operator
8484
// does not use the 'x' input.
8585
void select2nd(vertex *z, const bool *x, const vertex *y)
8686
{

experimental/algorithm/LAGr_Modularity.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
//------------------------------------------------------------------------------
1717

18-
// FIXME: ready to consider for src
18+
// TODO: ready to consider for src
1919

2020
// The modularity (Q) of a graph clustering C is defined as (directed case):
2121
//

experimental/algorithm/LAGr_PartitionQuality.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515

1616
//------------------------------------------------------------------------------
1717

18-
// FIXME: ready to consider for src
19-
// FIXME: define the input vector c that defines the cluster assignment
18+
// TODO: ready to consider for src
19+
// TODO: define the input vector c that defines the cluster assignment
2020

2121
// The coverage of a graph clustering C ( Cov(C) ) is defined as the ratio of
2222
// intra-cluster edges to the total edges in a graph. The performance of a graph

experimental/algorithm/LAGr_PeerPressureClustering.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,8 @@
1515

1616
//------------------------------------------------------------------------------
1717

18-
// FIXME: ready to consider for src
19-
// FIXME: define the output vector c that defines the cluster assignment
20-
// FIXME: some unused variables (the vector c)
18+
// TODO: ready to consider for src
19+
// TODO: define the output vector c_f that defines the cluster assignment
2120

2221
#define LG_FREE_WORK \
2322
{ \
@@ -36,7 +35,6 @@
3635
GrB_free(&E); \
3736
GrB_free(&I); \
3837
GrB_free(&ones); \
39-
GrB_free(&c); \
4038
LAGraph_Free((void **)&m_index_values, NULL); \
4139
LAGraph_Free((void **)&CfI, NULL); \
4240
LAGraph_Free((void **)&CfJ, NULL); \
@@ -90,7 +88,6 @@ int LAGr_PeerPressureClustering(
9088

9189
GrB_Index *m_index_values = NULL;
9290
GrB_Index *CfI = NULL, *CfJ = NULL;
93-
GrB_Vector c = NULL;
9491

9592
//--------------------------------------------------------------------------
9693
// check inputs

experimental/algorithm/LAGr_TriangleCount_GPU.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
//------------------------------------------------------------------------------
1717

18-
// FIXME: this is a rough test of the GraphBLAS GPU methods for triangle
18+
// TODO: this is a rough test of the GraphBLAS GPU methods for triangle
1919
// counting. It will not appear as a user-callable algorithm.
2020

2121
// Count the number of triangles in a graph,

experimental/algorithm/LAGraph_AllKCore.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@
3535

3636
#include "LG_internal.h"
3737

38-
// FIXME: need both basic and expert methods; this is mixed
39-
// FIXME: match filename to function name (this name is OK)
38+
// TODO: need both basic and expert methods; this is mixed
39+
// TODO: match filename to function name (this name is OK)
4040
// vanilla OK: no GxB used here
4141

4242
int LAGraph_KCore_All
@@ -75,7 +75,7 @@ int LAGraph_KCore_All
7575
LG_ASSERT_MSG (false, -1005, "G->A must be symmetric") ;
7676
}
7777

78-
// FIXME: in basic: compute it, this is Advanced:
78+
// TODO: in basic: compute it, this is Advanced:
7979
// no self edges can be present
8080
LG_ASSERT_MSG (G->nself_edges == 0, -1004, "G->nself_edges must be zero") ;
8181

@@ -84,7 +84,7 @@ int LAGraph_KCore_All
8484
GrB_Index n, todo, nvals, maxDeg ;
8585
GRB_TRY (GrB_Matrix_nrows(&n, A)) ;
8686

87-
// FIXME: do not call Cached in an advanced algorithm, this is Basic:
87+
// TODO: do not call Cached in an advanced algorithm, this is Basic:
8888
//create deg vector using out_degree property
8989
LG_TRY (LAGraph_Cached_OutDegree(G, msg)) ;
9090

@@ -106,7 +106,7 @@ int LAGraph_KCore_All
106106
//change deg vector to int32 if needed
107107
if (int_type == GrB_INT32)
108108
{
109-
// FIXME: deg is freed; it should never have been constructed above
109+
// TODO: deg is freed; it should never have been constructed above
110110
GrB_free (&deg) ;
111111
GRB_TRY (GrB_Vector_new(&deg, int_type, n)) ;
112112
GRB_TRY (GrB_assign (deg, G->out_degree, NULL, G->out_degree, GrB_ALL, n, NULL)) ;

experimental/algorithm/LAGraph_AllKTruss.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
// todo: consider LAGraph_KTrussNext to compute the (k+1)-truss from the
5353
// k-truss
5454

55-
// FIXME: ready for src
55+
// TODO: ready for src
5656

5757
#define LG_FREE_ALL \
5858
{ \

experimental/algorithm/LAGraph_Coarsen_Matching.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
//------------------------------------------------------------------------------
1111

12-
// FIXME: ready for src? need a vanilla non-GxB, and incidence graphs.
12+
// TODO: ready for src? need a vanilla non-GxB, and incidence graphs.
1313

1414
/*
1515
This method is used to coarsen an undirected graph. The coarsening is based on a maximal matching,

0 commit comments

Comments
 (0)