Complex number handling

[chihaoy]

[nix-shell:~/SparseRooflineBenchmark/example]# which gcc
/nix/store/ii75mhh7sxl11167m1b86p0qrjsjyjmd-gcc-wrapper-14-20241116/bin/gcc

And I compile in the nix-shell using (g++ -o spgemm spgemm.cpp -lhdf5 -lcjson -lbsp -std=c++20)

[nix-shell:~/SparseRooflineBenchmark/example]# uname -a
Linux vultr 6.8.0-54-generic #56-Ubuntu SMP PREEMPT_DYNAMIC Sat Feb 8 00:37:57 UTC 2025 x86_64 GNU/Linux

error occured:

[nix-shell:/SparseRooflineBenchmark/example]# g++ -o spgemm spgemm.cpp -lhdf5 -lcjson -lbsp -std=c++20
In file included from /nix/store/v9b8az8hxq6286mlyghhc66nnbqpnh1f-binsparse-reference-c/include/binsparse/detail/detail.h:9,
from /nix/store/v9b8az8hxq6286mlyghhc66nnbqpnh1f-binsparse-reference-c/include/binsparse/binsparse.h:13,
from spgemm.cpp:12:
/nix/store/v9b8az8hxq6286mlyghhc66nnbqpnh1f-binsparse-reference-c/include/binsparse/detail/declamp_values.h: In function ‘void bsp_matrix_declamp_values(bsp_matrix_t)’:
/nix/store/v9b8az8hxq6286mlyghhc66nnbqpnh1f-binsparse-reference-c/include/binsparse/detail/declamp_values.h:42:32: error: unable to find numeric literal operator ‘operator""j’
42 | values[i] = real_value + 1j * imaginary_value;
| ^
/nix/store/v9b8az8hxq6286mlyghhc66nnbqpnh1f-binsparse-reference-c/include/binsparse/detail/declamp_values.h:42:32: note: use ‘-fext-numeric-literals’ to enable more built-in suffixes
In file included from /nix/store/v9b8az8hxq6286mlyghhc66nnbqpnh1f-binsparse-reference-c/include/binsparse/binsparse.h:18:
/nix/store/v9b8az8hxq6286mlyghhc66nnbqpnh1f-binsparse-reference-c/include/binsparse/matrix_market/matrix_market_read.h: In function ‘bsp_matrix_t bsp_mmread_explicit_array(const char*, bsp_type_t, bsp_type_t)’:
/nix/store/v9b8az8hxq6286mlyghhc66nnbqpnh1f-binsparse-reference-c/include/binsparse/matrix_market/matrix_market_read.h:91:44: error: unable to find numeric literal operator ‘operator""j’
91 | double _Complex value = real_value + 1j * imaginary_value;
| ^~
/nix/store/v9b8az8hxq6286mlyghhc66nnbqpnh1f-binsparse-reference-c/include/binsparse/matrix_market/matrix_market_read.h:91:44: note: use ‘-fext-numeric-literals’ to enable more built-in suffixes
/nix/store/v9b8az8hxq6286mlyghhc66nnbqpnh1f-binsparse-reference-c/include/binsparse/matrix_market/matrix_market_read.h: In function ‘bsp_matrix_t bsp_mmread_explicit_coordinate(const char*, bsp_type_t, bsp_type_t)’:
/nix/store/v9b8az8hxq6286mlyghhc66nnbqpnh1f-binsparse-reference-c/include/binsparse/matrix_market/matrix_market_read.h:210:44: error: unable to find numeric literal operator ‘operator""j’
210 | double _Complex value = real_value + 1j * complex_value;
| ^~

They are all complex number issue

[BenBrock]

This is a bug in Clang. I just implemented a workaround in #17, which should fix the issue. Let me know if this resolves your issue.

[BenBrock]

Note that the previous PR I mentioned actually fixed a different issue. This issue with complex numbers is about the use of complex number literals. Complex number literals require the flag -fext-numeric-literals or any of the -std=gnu++20 series of standard flags.

This issue should be truly fixed with #18, which re-writes the code to avoid using complex number literals entirely. @chihaoy please test this and let me know if things work for you without the -fext-numeric-literals or other GNU flags.

[chihaoy]

I just tested. Without -fext-numeric-literalsm it works, but I still need to include --std=c++20 and the minimal command that makes it work is

c++ spgemm.cpp -lhdf5 -lcjson -lbinsparse-rc --std=c++20

[BenBrock]

PR #18 should have fixed this issue, and -fext-numeric-literals, so I'm closing this issue.