Skip to content

Commit b35b680

Browse files
Opted for Task instead of async-let
1 parent 127ec68 commit b35b680

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

Tests/DataLoaderTests/DataLoaderAsyncTests.swift

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,17 +85,24 @@ final class DataLoaderAsyncTests: XCTestCase {
8585
return await task.value
8686
}
8787

88-
async let value1 = identityLoader.load(key: 1, on: eventLoopGroup)
89-
async let value2 = identityLoader.load(key: 2, on: eventLoopGroup)
88+
// Normally async-let is a better option that using explicit Task, but the test machine fails to use async let multiple times already
89+
// async let value1 = identityLoader.load(key: 1, on: eventLoopGroup)
90+
// async let value2 = identityLoader.load(key: 2, on: eventLoopGroup)
91+
let value1 = Task {
92+
try await identityLoader.load(key: 1, on: eventLoopGroup)
93+
}
94+
let value2 = Task {
95+
try await identityLoader.load(key: 2, on: eventLoopGroup)
96+
}
9097

9198
/// Have to wait for a split second because Tasks may not be executed before this statement
9299
try await Task.sleep(nanoseconds: 500_000_000)
93100

94101
XCTAssertNoThrow(try identityLoader.execute())
95102

96-
let result1 = try await value1
103+
let result1 = try await value1.value
97104
XCTAssertEqual(result1, 1)
98-
let result2 = try await value2
105+
let result2 = try await value2.value
99106
XCTAssertEqual(result2, 2)
100107

101108
let loadCalls = await LoadCalls.shared.loadCalls

0 commit comments

Comments
 (0)