Skip to content

Commit cf261ba

Browse files
author
Brandon Schoenfeld
committed
refactor: prefer guard style in Channel.fulfill and .fail
1 parent 53d7c9f commit cf261ba

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

Sources/AsyncDataLoader/Channel.swift

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8,32 +8,32 @@ typealias Waiter<Success, Failure> = CheckedContinuation<Success, Error>
88
extension Channel {
99
@discardableResult
1010
func fulfill(_ success: Success) -> Bool {
11-
if result == nil {
12-
result = .success(success)
11+
guard result == nil else {
12+
return true
13+
}
1314

14-
while let waiter = waiters.popLast() {
15-
waiter.resume(returning: success)
16-
}
15+
result = .success(success)
1716

18-
return false
17+
while let waiter = waiters.popLast() {
18+
waiter.resume(returning: success)
1919
}
2020

21-
return true
21+
return false
2222
}
2323

2424
@discardableResult
2525
func fail(_ failure: Failure) -> Bool {
26-
if result == nil {
27-
result = .failure(failure)
26+
guard result == nil else {
27+
return true
28+
}
2829

29-
while let waiter = waiters.popLast() {
30-
waiter.resume(throwing: failure)
31-
}
30+
result = .failure(failure)
3231

33-
return false
32+
while let waiter = waiters.popLast() {
33+
waiter.resume(throwing: failure)
3434
}
3535

36-
return true
36+
return false
3737
}
3838

3939
var value: Success {

0 commit comments

Comments
 (0)